Re: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

2012-10-02 Thread Michal Simek
On 10/01/2012 06:52 PM, Tom Rini wrote: On Sat, Sep 29, 2012 at 11:52:58PM +0200, Marek Vasut wrote: This serial driver had wrong name of the source file for some time now. The name of the driver was serial.c instead of any more logical and fitting name. Thus, rename the driver source file to s

Re: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

2012-10-01 Thread Tom Rini
On Sat, Sep 29, 2012 at 11:52:58PM +0200, Marek Vasut wrote: > This serial driver had wrong name of the source file for some time > now. The name of the driver was serial.c instead of any more logical > and fitting name. Thus, rename the driver source file to serial_ns16550.c > and be done with it

Re: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

2012-10-01 Thread Marek Vasut
Dear Michal Simek, [...] > > Would it be better just use this structure? > > #ifdef CONFIG_SYS_NS16550_COM1 > [0] = (NS16550_t)CONFIG_SYS_NS16550_COM1, > #endif [...] > > You are using two coding styles in this file. > One has function return value on one line and then function name >

Re: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

2012-09-30 Thread Marek Vasut
Dear Michal Simek, [...] > You are using two coding styles in this file. Won't surprise me if there were even more. > One has function return value on one line and then function name > and the second function return value on one line with function name. > Will be good to unify it to look the sa

Re: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

2012-09-30 Thread Michal Simek
On 09/29/2012 11:52 PM, Marek Vasut wrote: This serial driver had wrong name of the source file for some time now. The name of the driver was serial.c instead of any more logical and fitting name. Thus, rename the driver source file to serial_ns16550.c and be done with it. Signed-off-by: Marek V

[U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

2012-09-29 Thread Marek Vasut
This serial driver had wrong name of the source file for some time now. The name of the driver was serial.c instead of any more logical and fitting name. Thus, rename the driver source file to serial_ns16550.c and be done with it. Signed-off-by: Marek Vasut Cc: Marek Vasut Cc: Tom Rini Cc: Anat