Re: [U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor

2010-01-18 Thread John Rigby
Stefano, There is a patch in my mx25 series that factors out a lot of SOC specifics from the fec driver including clocks. It might be useful here. John On Mon, Jan 18, 2010 at 5:19 AM, Stefano Babic wrote: > Wolfgang Denk wrote: >> Dear Stefano Babic, > > Hi Wolfgang, > >> >> I'm not sure. Her

Re: [U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor

2010-01-18 Thread Stefano Babic
Wolfgang Denk wrote: > Dear Stefano Babic, Hi Wolfgang, > > I'm not sure. Here is where we enable the FEC because we want to use > it in a network command, right? No, the fec_probe() function is called as part of the cpu_eth_init() and sets the callbacks, among the other things. It is called a

Re: [U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor

2010-01-18 Thread Wolfgang Denk
Dear Stefano Babic, In message <4b542b4e.4000...@denx.de> you wrote: > > >> +#ifndef CONFIG_MX51 > >> + struct pll_regs *pll = (struct pll_regs *)IMX_PLL_BASE; > >> > >>/* enable FEC clock */ > >>writel(readl(&pll->pccr1) | PCCR1_HCLK_FEC, &pll->pccr1); > >>writel(readl(&pll->pccr0)

Re: [U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor

2010-01-18 Thread Stefano Babic
Wolfgang Denk wrote: > Dear Stefano Babic, > Hi Wolfgang, >> -#include >> #include >> +#ifndef CONFIG_MX51 >> +#include imx_get_ahbclk >> +#endif > > Can we not implement the clock stuff for the iMX51 in such a way that > we don't need #ifdef's here? Good hint, I do it ! > >> @@ -108,6 +

Re: [U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor

2010-01-17 Thread Wolfgang Denk
Dear Stefano Babic, In message <1263212760-27272-7-git-send-email-sba...@denx.de> you wrote: > The patch add support for the Freescale mx51 processor > to the FEC ethernet driver. > > Signed-off-by: Stefano Babic > --- > drivers/net/fec_mxc.c | 57 > ++

[U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor

2010-01-11 Thread Stefano Babic
The patch add support for the Freescale mx51 processor to the FEC ethernet driver. Signed-off-by: Stefano Babic --- drivers/net/fec_mxc.c | 57 ++--- 1 files changed, 35 insertions(+), 22 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net