Re: [U-Boot] [PATCH 6/8 V4] I2C: Modify the I2C driver for EXYNOS5

2012-06-20 Thread Joonyoung Shim
2012/6/20 Rajeshwari Birje : > Hi Minkyu Kang, > > This being I2C driver code should not have any dependency on EVT0 or EVT1. I mean *all* arch and driver codes for Exynos5250 should support EVT1 only. Thanks. > > Regards, > Rajeshwari Shinde. > > On Wed, Jun 20, 2012 at 2:01 PM, Minkyu Kang wr

Re: [U-Boot] [PATCH 6/8 V4] I2C: Modify the I2C driver for EXYNOS5

2012-06-20 Thread Rajeshwari Birje
Hi Minkyu Kang, This being I2C driver code should not have any dependency on EVT0 or EVT1. Regards, Rajeshwari Shinde. On Wed, Jun 20, 2012 at 2:01 PM, Minkyu Kang wrote: > Dear Rajeshwari Birje, > > On 19 June 2012 19:57, Rajeshwari Birje wrote: >> Hi Joonyoung Shim, >> >> On Tue, Jun 19, 201

Re: [U-Boot] [PATCH 6/8 V4] I2C: Modify the I2C driver for EXYNOS5

2012-06-20 Thread Minkyu Kang
Dear Rajeshwari Birje, On 19 June 2012 19:57, Rajeshwari Birje wrote: > Hi Joonyoung Shim, > > On Tue, Jun 19, 2012 at 1:20 PM, Joonyoung Shim wrote: >> Hi, >> >> I add some comments at the below. >> > -- ok >> And current SMDK5250 uses Exynos5250 EVT0 base codes, >> but i know the kernel suppor

Re: [U-Boot] [PATCH 6/8 V4] I2C: Modify the I2C driver for EXYNOS5

2012-06-19 Thread Rajeshwari Birje
Hi Joonyoung Shim, On Tue, Jun 19, 2012 at 1:20 PM, Joonyoung Shim wrote: > Hi, > > I add some comments at the below. > -- ok > And current SMDK5250 uses Exynos5250 EVT0 base codes, > but i know the kernel supports only Exynos5250 EVT1. > > So, let's remove Exynos5250 EVT0 codes and add EVT1 code

Re: [U-Boot] [PATCH 6/8 V4] I2C: Modify the I2C driver for EXYNOS5

2012-06-19 Thread Joonyoung Shim
Hi, I add some comments at the below. And current SMDK5250 uses Exynos5250 EVT0 base codes, but i know the kernel supports only Exynos5250 EVT1. So, let's remove Exynos5250 EVT0 codes and add EVT1 codes at the u-boot also. Could you follow up it? Thanks. 2012/6/19 Rajeshwari Shinde : > This pa

[U-Boot] [PATCH 6/8 V4] I2C: Modify the I2C driver for EXYNOS5

2012-06-19 Thread Rajeshwari Shinde
This patch modifies the S3C I2C driver to suppport EXYNOS5. The cahnges made to driver are as follows: - I2C base address is passed as a parameter to many functions to avoid multiple #ifdef - I2C init for Exynos5 is made as different function. - Channel initialisatio