Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-03-11 Thread Wolfgang Denk
Dear Dirk, In message <49b8021c.8080...@googlemail.com> you wrote: > > For the die ID (former serial number) patch [2] I will send an update > with better commit message as requested by Wolfgang, soon (weekend?). > Hopefully this will still be merged then in this release (?). ACK from me. > Do

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-03-11 Thread Dirk Behme
Jean-Christophe PLAGNIOL-VILLARD wrote: > On 19:55 Thu 12 Feb , Dirk Behme wrote: >> OMAP3 core changes necessary for MUSB >> >> Signed-off-by: Dirk Behme >> >> --- > will you send a new version soon or this will wait the next release? The developers which did the initial MUSB support for OMA

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-03-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:55 Thu 12 Feb , Dirk Behme wrote: > OMAP3 core changes necessary for MUSB > > Signed-off-by: Dirk Behme > > --- will you send a new version soon or this will wait the next release? Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.d

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-03-01 Thread Wolfgang Denk
Dear Dirk, In message <49aa9b19.6060...@googlemail.com> you wrote: > > > Will it get an ACK if we change ... > > and then call enable/disable from MUSB code at appropriate places? > > Any hint if changing the patch doing something like above as proposed > some days ago [1] would get an ack? I'd

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-03-01 Thread Dirk Behme
Dirk Behme wrote: > Wolfgang Denk wrote: ... >>> Other point of view of "enabling clock only if need" can be "enable >>> clock only if code is compiled into uboot _and_ is accessed (e.g. by >>> serial output over USB)" (i.e. runtime enable). I think this what >> >> Yes, that is the intention. >

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-25 Thread Dirk Behme
Wolfgang Denk wrote: > Dear Dirk, > > In message <49a427d1.6050...@googlemail.com> you wrote: >> Wolfgang Denk wrote: >>> Dear Nishanth Menon, >>> >>> In message <49a296f0.4000...@gmail.com> you wrote: > He probably wants to say that clocks should be enabled only when "usb > start" is issu

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-24 Thread Wolfgang Denk
Dear Dirk, In message <49a427d1.6050...@googlemail.com> you wrote: > Wolfgang Denk wrote: > > Dear Nishanth Menon, > > > > In message <49a296f0.4000...@gmail.com> you wrote: > >>> He probably wants to say that clocks should be enabled only when "usb > >>> start" is issued, as you might have u-boo

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-24 Thread Dirk Behme
Wolfgang Denk wrote: > Dear Nishanth Menon, > > In message <49a296f0.4000...@gmail.com> you wrote: >>> He probably wants to say that clocks should be enabled only when "usb >>> start" is issued, as you might have u-boot compiled with USB defines >>> set, but never actually use USB. > > Correct.

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-23 Thread Wolfgang Denk
Dear Nishanth Menon, In message <49a296f0.4000...@gmail.com> you wrote: > > > He probably wants to say that clocks should be enabled only when "usb > > start" is issued, as you might have u-boot compiled with USB defines > > set, but never actually use USB. Correct. > Comparing having all clock

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-23 Thread Dirk Behme
Nishanth Menon wrote: > Grazvydas Ignotas said the following on 02/23/2009 02:13 PM: > +#ifdef CONFIG_MUSB > +/* Enable the MUSB interface clock */ > +sr32(&prcm_base->iclken1_core, 4, 1, 0x1); > +#endif > the design of u-boot is to enagle the IP only when

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-23 Thread Nishanth Menon
Grazvydas Ignotas said the following on 02/23/2009 02:13 PM: +#ifdef CONFIG_MUSB +/* Enable the MUSB interface clock */ +sr32(&prcm_base->iclken1_core, 4, 1, 0x1); +#endif >>> the design of u-boot is to enagle the IP only when he use it >>> so please do not

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-23 Thread Grazvydas Ignotas
On Sun, Feb 22, 2009 at 6:22 PM, Dirk Behme wrote: > Dear Jean-Christophe, > > Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 19:55 Thu 12 Feb , Dirk Behme wrote: >>> OMAP3 core changes necessary for MUSB >>> >>> Signed-off-by: Dirk Behme >>> >>> --- >>> Note: OMAP3 USB code will be sent later

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-22 Thread Dirk Behme
Dear Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 19:55 Thu 12 Feb , Dirk Behme wrote: >> OMAP3 core changes necessary for MUSB >> >> Signed-off-by: Dirk Behme >> >> --- >> Note: OMAP3 USB code will be sent later to USB maintainer, so >> CONFIG_MUSB isn't used anywhere

Re: [U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:55 Thu 12 Feb , Dirk Behme wrote: > OMAP3 core changes necessary for MUSB > > Signed-off-by: Dirk Behme > > --- > Note: OMAP3 USB code will be sent later to USB maintainer, so > CONFIG_MUSB isn't used anywhere yet. This will avoid > USB maintainer to change OMAP3 core files

[U-Boot] [PATCH 6/7 v2] OMAP3: Add OMAP3 core changes for MUSB

2009-02-12 Thread Dirk Behme
OMAP3 core changes necessary for MUSB Signed-off-by: Dirk Behme --- Note: OMAP3 USB code will be sent later to USB maintainer, so CONFIG_MUSB isn't used anywhere yet. This will avoid USB maintainer to change OMAP3 core files. cpu/arm_cortexa8/omap3/clock.c |5 + include