Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-19 Thread Vipin Kumar
Dear Wolfgang, > In message <1260955110-5656-6-git-send-email-vipin.ku...@st.com> you wrote: >> >> Signed-off-by: Vipin > ... >> +int misc_init_r(void) >> +{ >> +#if defined(CONFIG_CMD_NET) >> +     uchar mac_id[6]; >> + >> +     if (!i2c_read_mac(mac_id)) >> +             eth_setenv_enetaddr("et

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-18 Thread Vipin Kumar
Dear Wolfgang, > In message <1261090481.11634.5308.ca...@localhost.localdomain> you wrote: >> >> > > I haven't looked at the code differences between the sp3xx boards, but >> > > you might be able to use 1 common board file/header file to support them >> > > all.  For example, take a look at the M

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-17 Thread Wolfgang Denk
Dear Peter Tyser, In message <1261090481.11634.5308.ca...@localhost.localdomain> you wrote: > > > > I haven't looked at the code differences between the sp3xx boards, but > > > you might be able to use 1 common board file/header file to support them > > > all. For example, take a look at the M54

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-17 Thread Peter Tyser
Hi Wolfgang, > > I haven't looked at the code differences between the sp3xx boards, but > > you might be able to use 1 common board file/header file to support them > > all. For example, take a look at the M5475AFE_config rule in > > U-Boot's ./Makefile. Some extra code in the Makefile and som

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-17 Thread Wolfgang Denk
Dear Peter Tyser, In message <1260988086.11634.3576.ca...@localhost.localdomain> you wrote: > > I see. It'd be nice to put some of the above information in the U-Boot > commit logs to give people an idea about what's going on without having > to use google, etc. ...and even better in some doc/R

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-16 Thread Wolfgang Denk
Dear Vipin KUMAR, In message <1260955110-5656-6-git-send-email-vipin.ku...@st.com> you wrote: > > Signed-off-by: Vipin ... > +int misc_init_r(void) > +{ > +#if defined(CONFIG_CMD_NET) > + uchar mac_id[6]; > + > + if (!i2c_read_mac(mac_id)) > + eth_setenv_enetaddr("ethaddr", m

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-16 Thread Peter Tyser
Hi Arm, > > It'd also be nice to give a description of each board and SOC you add. > > Eg what's the difference between the 300, 310, 320, 600? What > > peripherals do they support? What does SPEAr stand for? More commit > > messages in general wouldn't hurt:) > > > SPEAr (Structured Proce

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-16 Thread Armando VISCONTI
Ciao Peter, > The changes to board/* should be moved out of this patch and into patch > 9 "SPEAr600 build support added". Same comment for > include/configs/spear600.h. > Tomorrow we will resend patch_5 and patch_9. > It'd also be nice to give a description of each board and SOC you add. > Eg

Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-16 Thread Peter Tyser
On Wed, 2009-12-16 at 14:48 +0530, Vipin KUMAR wrote: > Signed-off-by: Vipin > --- > board/spear/common/spr_lowlevel_init.S | 202 ++ > board/spear/common/spr_misc.c | 270 > > board/spear/spear600/Makefile |

[U-Boot] [PATCH 5/9] SPEAr600 SoC support added

2009-12-16 Thread Vipin KUMAR
Signed-off-by: Vipin --- board/spear/common/spr_lowlevel_init.S | 202 ++ board/spear/common/spr_misc.c | 270 board/spear/spear600/Makefile | 52 + board/spear/spear600/config.mk | 39 ++