Re: [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-25 Thread Miquel Raynal
Hi Boris, On Wed, 24 Jan 2018 09:16:19 +0100 Boris Brezillon wrote: > On Wed, 24 Jan 2018 01:44:51 +0100 > Miquel Raynal wrote: > > > Because using DMA implementation is not generic and was not developped > > to work on SoCs like A33, migrate the SPL to use PIO. > > > > Signed-off-by: Miquel

Re: [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-25 Thread Miquel Raynal
Hi Maxime, I have some doubts about your comments, see below. On Wed, 24 Jan 2018 09:06:26 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Jan 24, 2018 at 01:44:51AM +0100, Miquel Raynal wrote: > > Because using DMA implementation is not generic and was not developped > > to work on SoCs like A33

Re: [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-24 Thread Maxime Ripard
On Wed, Jan 24, 2018 at 09:26:37AM +0100, Boris Brezillon wrote: > > > > > > #define NFC_READ_CMD_OFFSET 0 > > > #define NFC_RANDOM_READ_CMD0_OFFSET 8 > > > @@ -80,22 +71,6 @@ > > > #define NFC_CMD_RNDOUT 0x05 > > > #define NFC_CMD_READSTART 0x30 > > > > > > -#d

Re: [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-24 Thread Boris Brezillon
On Wed, 24 Jan 2018 09:06:26 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Jan 24, 2018 at 01:44:51AM +0100, Miquel Raynal wrote: > > Because using DMA implementation is not generic and was not developped > > to work on SoCs like A33, migrate the SPL to use PIO. > > > > Signed-off-by: Miquel Ray

Re: [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-24 Thread Boris Brezillon
On Wed, 24 Jan 2018 01:44:51 +0100 Miquel Raynal wrote: > Because using DMA implementation is not generic and was not developped > to work on SoCs like A33, migrate the SPL to use PIO. > > Signed-off-by: Miquel Raynal > --- > board/sunxi/board.c | 4 +- > drivers/mtd/nand/sunxi

Re: [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-24 Thread Maxime Ripard
Hi, On Wed, Jan 24, 2018 at 01:44:51AM +0100, Miquel Raynal wrote: > Because using DMA implementation is not generic and was not developped > to work on SoCs like A33, migrate the SPL to use PIO. > > Signed-off-by: Miquel Raynal I guess the issue is slightly different than what you're saying, o

[U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA

2018-01-23 Thread Miquel Raynal
Because using DMA implementation is not generic and was not developped to work on SoCs like A33, migrate the SPL to use PIO. Signed-off-by: Miquel Raynal --- board/sunxi/board.c | 4 +- drivers/mtd/nand/sunxi_nand_spl.c | 167 +- 2 files change