Dear Wonfgang,
On 3/6/2012 12:35 AM, Wolfgang Denk wrote:
Dear Amit Virdi,
In message<4f54af08.1030...@st.com> you wrote:
Surprisingly, I could still not find "true" and "false" defined for ARM
architecture or in a common file that I can include. Here's what grep
gives me
So don't use thes
Dear Amit Virdi,
In message <4f54af08.1030...@st.com> you wrote:
>
> Surprisingly, I could still not find "true" and "false" defined for ARM
> architecture or in a common file that I can include. Here's what grep
> gives me
So don't use these.
In theory, any use of #define TRUE / FALSE or enum
Dear Mike,
On 3/3/2012 12:08 AM, Mike Frysinger wrote:
On Friday 02 March 2012 06:40:07 Amit Virdi wrote:
On 3/1/2012 12:41 AM, Mike Frysinger wrote:
+ u32 phy_configured;
+#define FALSE(0)
+#define TRUE (!FALSE)
NAK: we already have "true" and "false" and the "bool" type
On Friday 02 March 2012 06:40:07 Amit Virdi wrote:
> On 3/1/2012 12:41 AM, Mike Frysinger wrote:
> >> + u32 phy_configured;
> >>
> >> > +#define FALSE (0)
> >> > +#define TRUE (!FALSE)
> >
> > NAK: we already have "true" and "false" and the "bool" type. use those
> > instead.
>
> Are you
On 3/1/2012 12:41 AM, Mike Frysinger wrote:
+ u32 phy_configured;
> +#define FALSE(0)
> +#define TRUE (!FALSE)
NAK: we already have "true" and "false" and the "bool" type. use those
instead.
Are you sure Mike? I couldn't find in u-boot code "TRUE" and "FALSE"
defined in any
On Wednesday 29 February 2012 05:37:24 Amit Virdi wrote:
> --- a/drivers/net/designware.h
> +++ b/drivers/net/designware.h
> @@ -238,6 +238,10 @@ struct dw_eth_dev {
> u32 duplex;
> u32 tx_currdescnum;
> u32 rx_currdescnum;
> + u32 phy_configured;
> +#define FALSE(0)
>
From: Vipin Kumar
Phy autonegotiation works only when the ethernet cable is plugged in.
Since the phy was configured only at the init time, a plugged in cable
was necessary to initialize the phy properly.
This patch keeps a flag to check if the phy initialization has
succeeded, and calls configu
7 matches
Mail list logo
