Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-24 Thread Lukasz Majewski
Hi Mike, > On Monday 23 July 2012 12:01:04 Lukasz Majewski wrote: > > Dear Mike, > > > On Tuesday 03 July 2012 05:38:09 Lukasz Majewski wrote: > > > > --- /dev/null > > > > +++ b/common/cmd_dfu.c > > > > > > > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const > > > > argv[]) > > >

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-24 Thread Mike Frysinger
On Monday 23 July 2012 12:01:04 Lukasz Majewski wrote: > Dear Mike, > > On Tuesday 03 July 2012 05:38:09 Lukasz Majewski wrote: > > > --- /dev/null > > > +++ b/common/cmd_dfu.c > > > > > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const > > > argv[]) > > > > static > > It can be s

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-23 Thread Lukasz Majewski
Dear Mike, > On Tuesday 03 July 2012 05:38:09 Lukasz Majewski wrote: > > --- /dev/null > > +++ b/common/cmd_dfu.c > > > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const > > argv[]) > > static It can be static (static int do_dfu). On the other hand the U_BOOT_CMD macro defines: i

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-21 Thread Marek Vasut
Dear Mike Frysinger, > On Friday 20 July 2012 17:11:33 Marek Vasut wrote: > > Dear Mike Frysinger, > > > > > On Friday 20 July 2012 07:33:49 Marek Vasut wrote: > > > > Dear Mike Frysinger, > > > > > > > > > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote: > > > > > > > Putting there the __f

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-21 Thread Mike Frysinger
On Friday 20 July 2012 17:11:33 Marek Vasut wrote: > Dear Mike Frysinger, > > On Friday 20 July 2012 07:33:49 Marek Vasut wrote: > > > Dear Mike Frysinger, > > > > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote: > > > > > > Putting there the __func__ name would improve structure and speed > >

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-20 Thread Marek Vasut
Dear Mike Frysinger, > On Friday 20 July 2012 07:33:49 Marek Vasut wrote: > > Dear Mike Frysinger, > > > > > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote: > > > > > Putting there the __func__ name would improve structure and speed > > > > > up finding right place. > > > > > > > > And if

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-20 Thread Mike Frysinger
On Friday 20 July 2012 07:33:49 Marek Vasut wrote: > Dear Mike Frysinger, > > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote: > > > > Putting there the __func__ name would improve structure and speed up > > > > finding right place. > > > > > > And if you want to use even __LINE__, look up __

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-20 Thread Marek Vasut
Dear Mike Frysinger, > On Tuesday 03 July 2012 17:32:54 Marek Vasut wrote: > > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > > > +{ > > > + char *str_env = NULL, *env_bkp = NULL; > > > + static char *s = "dfu"; > > > + int ret = 0; > > > + > > > + if (argc < 3) > > > +

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-20 Thread Marek Vasut
Dear Mike Frysinger, > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote: > > > Putting there the __func__ name would improve structure and speed up > > > finding right place. > > > > And if you want to use even __LINE__, look up __stringify patch in the ML > > archives ;-) > > ugh, no, let's

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-19 Thread Mike Frysinger
On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote: > > Putting there the __func__ name would improve structure and speed up > > finding right place. > > And if you want to use even __LINE__, look up __stringify patch in the ML > archives ;-) ugh, no, let's not use __LINE__ anywhere other than

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-19 Thread Mike Frysinger
On Tuesday 03 July 2012 17:32:54 Marek Vasut wrote: > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > > +{ > > + char *str_env = NULL, *env_bkp = NULL; > > + static char *s = "dfu"; > > + int ret = 0; > > + > > + if (argc < 3) > > + return CMD_RET_USAGE;

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-19 Thread Mike Frysinger
On Tuesday 03 July 2012 05:38:09 Lukasz Majewski wrote: > --- /dev/null > +++ b/common/cmd_dfu.c > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) static > +{ > + char *str_env = NULL, *env_bkp = NULL; no need to assign NULL here. str_env should be const. > + s

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-04 Thread Marek Vasut
Dear Lukasz Majewski, > Hi Marek, > > > Dear Lukasz Majewski, > > > > > Support for u-boot's command line command "dfu > > > [list]". > > > > > > Signed-off-by: Lukasz Majewski > > > Signed-off-by: Kyungmin Park > > > Cc: Marek Vasut > > > --- > > > > [...] > > > > > +int do_dfu(cmd_tbl_

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-04 Thread Lukasz Majewski
Hi Marek, > Dear Lukasz Majewski, > > > Support for u-boot's command line command "dfu > > [list]". > > > > Signed-off-by: Lukasz Majewski > > Signed-off-by: Kyungmin Park > > Cc: Marek Vasut > > --- > > [...] > > > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const > > argv[]

Re: [U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-03 Thread Marek Vasut
Dear Lukasz Majewski, > Support for u-boot's command line command "dfu [list]". > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- [...] > +int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +{ > + char *str_env = NULL, *env_b

[U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-03 Thread Lukasz Majewski
Support for u-boot's command line command "dfu [list]". Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park Cc: Marek Vasut --- common/Makefile |1 + common/cmd_dfu.c | 81 ++ 2 files changed, 82 insertions(+), 0 deletions(-)