Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-25 Thread Stefano Babic
On 24/09/2017 13:27, Max Krummenacher wrote: > Hi > > > I propose to drop my patches in favor of  Fabio's solution. > > Agree, I will merge them. Regards, Stefano > Reviewed-by: Max Krummenacher > > > Max > > > *Von

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-25 Thread Stefano Babic
Hi Fabio, On 23/09/2017 17:11, Fabio Estevam wrote: > On Sat, Sep 23, 2017 at 10:01 AM, Fabio Estevam wrote: >> Hi Stefano, >> >> On Sat, Sep 23, 2017 at 5:43 AM, Stefano Babic wrote: >> >>> Max has already fixed apalis / colibri, see for example >>> http://patchwork.ozlabs.org/patch/817053/. I

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-24 Thread Max Krummenacher
Hi I propose to drop my patches in favor of Fabio's solution. Reviewed-by: Max Krummenacher Max Von: Anatolij Gustschin Gesendet: Samstag, 23. September 2017 21:06:57 An: Stefano Babic Cc: Fabio Estevam; u-boot@lists.denx.de; Max Krummenacher; Fabio Esteva

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-23 Thread Anatolij Gustschin
Hi Stefano, On Sat, 23 Sep 2017 10:43:55 +0200 Stefano Babic sba...@denx.de wrote: ... > Max has already fixed apalis / colibri, see for example > http://patchwork.ozlabs.org/patch/817053/. I will apply Max's patches > and drop 5/6 from your series. Anyway, thanks for having thought to > these tw

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-23 Thread Fabio Estevam
On Sat, Sep 23, 2017 at 10:01 AM, Fabio Estevam wrote: > Hi Stefano, > > On Sat, Sep 23, 2017 at 5:43 AM, Stefano Babic wrote: > >> Max has already fixed apalis / colibri, see for example >> http://patchwork.ozlabs.org/patch/817053/. I will apply Max's patches >> and drop 5/6 from your series. An

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-23 Thread Fabio Estevam
Hi Stefano, On Sat, Sep 23, 2017 at 5:43 AM, Stefano Babic wrote: > Max has already fixed apalis / colibri, see for example > http://patchwork.ozlabs.org/patch/817053/. I will apply Max's patches > and drop 5/6 from your series. Anyway, thanks for having thought to > these two boards, too. Yes,

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-23 Thread Stefano Babic
Hi Fabio, On 23/09/2017 04:45, Fabio Estevam wrote: > From: Fabio Estevam > > There is no need call setup_display() from SPL code, so move it to > board_init(), which executes only in U-Boot proper. > > Reported-by: Stefano Babic > Signed-off-by: Fabio Estevam > --- > board/toradex/apalis_im

[U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-22 Thread Fabio Estevam
From: Fabio Estevam There is no need call setup_display() from SPL code, so move it to board_init(), which executes only in U-Boot proper. Reported-by: Stefano Babic Signed-off-by: Fabio Estevam --- board/toradex/apalis_imx6/apalis_imx6.c | 8 1 file changed, 4 insertions(+), 4 delet