Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2013-01-23 Thread Nikita Kiryanov
On 01/23/2013 12:47 PM, Nikita Kiryanov wrote: Hi Albert, On 01/22/2013 09:37 AM, Albert ARIBAUD wrote: Hi Nikita, [...] Note that if the user address is constrained to be 4-byte-aligned, then only the "2 x 'B' 'M'" case would apply. I think a simpler way to implement something like this

Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2013-01-23 Thread Nikita Kiryanov
Hi Albert, On 01/22/2013 09:37 AM, Albert ARIBAUD wrote: Hi Nikita, [...] Barring that, we should at least protect lcd.c from this issue by making some sort of check for affected targets, or maybe limit the possible values for splashimage... This issue makes it way too easy to accidentally

Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2013-01-21 Thread Albert ARIBAUD
Hi Nikita, On Sun, 30 Dec 2012 16:39:06 +0200, Nikita Kiryanov wrote: > On 12/26/2012 04:27 PM, Jeroen Hofstee wrote: > > Hello Nikita, > > > > On 12/25/2012 09:56 AM, Nikita Kiryanov wrote: > >> > >>> fyi, I noticed that my board compiled with gcc 4.7.3 from ELDK 5.3 will > >>> trap if the bitm

Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2012-12-30 Thread Nikita Kiryanov
On 12/26/2012 04:27 PM, Jeroen Hofstee wrote: Hello Nikita, On 12/25/2012 09:56 AM, Nikita Kiryanov wrote: fyi, I noticed that my board compiled with gcc 4.7.3 from ELDK 5.3 will trap if the bitmap is not aligned. Aligned is a bit tricky though since the bitmap has the signature, e.g. "BM" pr

Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2012-12-26 Thread Jeroen Hofstee
Hello Nikita, On 12/25/2012 09:56 AM, Nikita Kiryanov wrote: fyi, I noticed that my board compiled with gcc 4.7.3 from ELDK 5.3 will trap if the bitmap is not aligned. Aligned is a bit tricky though since the bitmap has the signature, e.g. "BM" prepended and is thereafter 32 bit aligned (or

Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2012-12-25 Thread Nikita Kiryanov
Hi Jeroen, On 12/24/2012 10:55 AM, Jeroen Hofstee wrote: Hi Nikita, On 12/23/2012 08:03 AM, Nikita Kiryanov wrote: Add support for loading splash image from NAND Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- board/cm_t35/cm_t35.c| 61 +++

Re: [U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2012-12-24 Thread Jeroen Hofstee
Hi Nikita, On 12/23/2012 08:03 AM, Nikita Kiryanov wrote: Add support for loading splash image from NAND Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- board/cm_t35/cm_t35.c| 61 ++ include/configs/cm_t35.h |4 +++ 2 f

[U-Boot] [PATCH 5/5] cm-t35: add support for loading splash image from NAND

2012-12-22 Thread Nikita Kiryanov
Add support for loading splash image from NAND Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- board/cm_t35/cm_t35.c| 61 ++ include/configs/cm_t35.h |4 +++ 2 files changed, 65 insertions(+) diff --git a/board/cm_t35/cm_t35