Re: [U-Boot] [PATCH 4/8] buildman: Fix up a few code inconsistencies in toolchain.py

2016-03-12 Thread Simon Glass
On 7 March 2016 at 09:45, Joe Hershberger wrote: > On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: >> Normally we use a single quote for strings unless there is a reason not to >> (such as an embedded single quote). Fix a few counter-examples in this file. >> Also add a missing function-argume

Re: [U-Boot] [PATCH 4/8] buildman: Fix up a few code inconsistencies in toolchain.py

2016-03-07 Thread Joe Hershberger
On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: > Normally we use a single quote for strings unless there is a reason not to > (such as an embedded single quote). Fix a few counter-examples in this file. > Also add a missing function-argument comment. > > Signed-off-by: Simon Glass Reviewed-b

[U-Boot] [PATCH 4/8] buildman: Fix up a few code inconsistencies in toolchain.py

2016-03-06 Thread Simon Glass
Normally we use a single quote for strings unless there is a reason not to (such as an embedded single quote). Fix a few counter-examples in this file. Also add a missing function-argument comment. Signed-off-by: Simon Glass --- tools/buildman/toolchain.py | 11 ++- 1 file changed, 6 in