Re: [U-Boot] [PATCH 4/6] hush: fix segfault on syntax error

2014-11-01 Thread Simon Glass
Hi Rabin, On 29 October 2014 16:21, Rabin Vincent wrote: > Hush segfaults if it sees a syntax error while attempting to parse a > command: > > $ ./u-boot -c "'" > ... > syntax error > Segmentation fault (core dumped) > > This is due to a NULL pointer dereference of in_str->p in static_peek().

[U-Boot] [PATCH 4/6] hush: fix segfault on syntax error

2014-10-29 Thread Rabin Vincent
Hush segfaults if it sees a syntax error while attempting to parse a command: $ ./u-boot -c "'" ... syntax error Segmentation fault (core dumped) This is due to a NULL pointer dereference of in_str->p in static_peek(). The problem is that the exit condition for the loop in parse_stream_outer(