Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-16 Thread Nikita Kiryanov
On 03/16/2015 01:35 PM, Igor Grinberg wrote: On 03/16/15 10:32, Hannes Petermaier wrote: 2) I need in almost every "paint-function" the framebuffer base (cons.lcd_address) and the screen dimension. This information is stored in the static structure within lcd.c - i don't like to make this publi

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-16 Thread Igor Grinberg
On 03/16/15 10:32, Hannes Petermaier wrote: >> Hi Hannes, > Hi Igor, > +/* setup text-console */ +debug("[LCD] setting up console...\n"); +#ifdef CONFIG_LCD_ROTATION +lcd_init_console(lcd_base, + panel_info.vl_col, + panel_info.vl_r

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-16 Thread Hannes Petermaier
Nikita Kiryanov schrieb am 15.03.2015 19:56:31: > > Hi Hannes, Hi Nikita, many thanks for response. > > I second Grinberg's suggestion of a separate file and 0 degree default (also as a > fallback for invalid rotation value, see below). Okay - i will provide a V2 from this patch where i try to

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-16 Thread Hannes Petermaier
> Hi Hannes, Hi Igor, > >> +/* setup text-console */ > >> +debug("[LCD] setting up console...\n"); > >> +#ifdef CONFIG_LCD_ROTATION > >> +lcd_init_console(lcd_base, > >> + panel_info.vl_col, > >> + panel_info.vl_row, > >> + panel_info.vl_rot); > >>

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-15 Thread Nikita Kiryanov
Hi Hannes, I second Grinberg's suggestion of a separate file and 0 degree default (also as a fallback for invalid rotation value, see below). Some additional comments: On 03/11/2015 02:57 PM, Hannes Petermaier wrote: From: Hannes Petermaier Sometimes, for example if the display is mounted in

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-15 Thread Igor Grinberg
Hi Hannes, On 03/12/15 18:46, Hannes Petermaier wrote: > > On 2015-03-12 13:26, Igor Grinberg wrote: >> Hi Hannes, > Hi Igor, > thanks for response. >> #endif >> -/* Paint the logo and retrieve LCD base address */ >> -debug("[LCD] Drawing the logo...\n"); >> -#if defined(CONFIG_LCD_LOGO

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-12 Thread Hannes Petermaier
On 2015-03-12 13:26, Igor Grinberg wrote: Hi Hannes, Hi Igor, thanks for response. #endif - /* Paint the logo and retrieve LCD base address */ - debug("[LCD] Drawing the logo...\n"); -#if defined(CONFIG_LCD_LOGO) && !defined(CONFIG_LCD_INFO_BELOW_LOGO) - console_rows = (pan

Re: [U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-12 Thread Igor Grinberg
Hi Hannes, On 03/11/15 14:57, Hannes Petermaier wrote: > From: Hannes Petermaier > > Sometimes, for example if the display is mounted in portrait mode or even if > it > mounted landscape but rotated by 180 degrees, we need to rotate our content of > the display respectively the framebuffer, so

[U-Boot] [PATCH 4/4] common/lcd_console: introduce display/framebuffer rotation

2015-03-11 Thread Hannes Petermaier
From: Hannes Petermaier Sometimes, for example if the display is mounted in portrait mode or even if it mounted landscape but rotated by 180 degrees, we need to rotate our content of the display respectively the framebuffer, so that user can read the messages who are printed out. For this we int