Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message you wrote: > > I'm not sure I understand your comment. It sounds to me like you're saying > that fixup_silent_linux() (which already exists in u-boot code) shouldn't be > needed anymore in u-boot. ...and maybe you're considering it deprecated? I consider at leas

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-20 Thread Doug Anderson
Wolfgang, On Thu, Oct 20, 2011 at 7:42 AM, Wolfgang Denk wrote: > As before, I see very little (actually, none at all) need for such > function. Things like that should be handled usign environment > variables in a clever way. > > Please explain why you think this code is needed. > I'm not sur

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-20 Thread Wolfgang Denk
Dear Doug Anderson, In message <1319063459-4804-5-git-send-email-diand...@chromium.org> you wrote: > Signed-off-by: Doug Anderson > --- > common/cmd_bootm.c | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) As before, I see very little (actually, none at all) need for such f

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 18:46:20 Doug Anderson wrote: > On Wed, Oct 19, 2011 at 3:35 PM, Mike Frysinger wrote: > > On Wednesday 19 October 2011 18:30:59 Doug Anderson wrote: > > > + /* Add in earlyprintk */ > > > + original_str = "console=ttyS0,115200n8 root=/dev/mmcblk0p3 > > > > ea

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-19 Thread Doug Anderson
On Wed, Oct 19, 2011 at 3:35 PM, Mike Frysinger wrote: > On Wednesday 19 October 2011 18:30:59 Doug Anderson wrote: > > + /* Add in earlyprintk */ > > + original_str = "console=ttyS0,115200n8 root=/dev/mmcblk0p3 > earlyprintk"; > > + expected_str = "root=/dev/mmcblk0p3 console="; > >

Re: [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 18:30:59 Doug Anderson wrote: > + /* Add in earlyprintk */ > + original_str = "console=ttyS0,115200n8 root=/dev/mmcblk0p3 earlyprintk"; > + expected_str = "root=/dev/mmcblk0p3 console="; *choke* wtf just happened here ? -mike signature.asc Description: Th

[U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

2011-10-19 Thread Doug Anderson
Signed-off-by: Doug Anderson --- common/cmd_bootm.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c index f426e2f..c259bfb 100644 --- a/common/cmd_bootm.c +++ b/common/cmd_bootm.c @@ -1203,7 +1203,7 @@ U_BOOT_CMD( #ifdef C