Re: [U-Boot] [PATCH 30/69] x86: gpio: Correct GPIO setup ordering

2016-03-10 Thread Bin Meng
On Fri, Mar 11, 2016 at 1:55 PM, Bin Meng wrote: > On Mon, Mar 7, 2016 at 10:28 AM, Simon Glass wrote: >> The Intel GPIO driver can set up the GPIO pin mapping when the first GPIO >> is probed. However, it assumes that the first GPIO to be probed is in the >> first GPIO bank. If this is not the c

Re: [U-Boot] [PATCH 30/69] x86: gpio: Correct GPIO setup ordering

2016-03-10 Thread Bin Meng
On Mon, Mar 7, 2016 at 10:28 AM, Simon Glass wrote: > The Intel GPIO driver can set up the GPIO pin mapping when the first GPIO > is probed. However, it assumes that the first GPIO to be probed is in the > first GPIO bank. If this is not the case then the init will write to the > wrong registers.

[U-Boot] [PATCH 30/69] x86: gpio: Correct GPIO setup ordering

2016-03-06 Thread Simon Glass
The Intel GPIO driver can set up the GPIO pin mapping when the first GPIO is probed. However, it assumes that the first GPIO to be probed is in the first GPIO bank. If this is not the case then the init will write to the wrong registers. Fix this. Also add a note that this code is deprecated. We s