Re: [U-Boot] [PATCH 3/9] x86: Allow excluding reset handling code from u-boot.

2012-10-09 Thread Graeme Russ
Hi Simon, On Wed, Oct 10, 2012 at 10:11 AM, Simon Glass wrote: > > Looks good - yes I will prepare a new series to send likely on Thursday. > > Not that it matters for now, but who will define INCLUDE_X86_RESET_VECTOR? It's calculated in the Makefile as an inversion of CONFIG_X86_NO_RESET_VECT

Re: [U-Boot] [PATCH 3/9] x86: Allow excluding reset handling code from u-boot.

2012-10-09 Thread Simon Glass
Hi Graeme, On Tue, Oct 9, 2012 at 3:58 PM, Graeme Russ wrote: > Hi Simon, > > On Wed, Oct 10, 2012 at 8:15 AM, Simon Glass wrote: > diff --git a/arch/x86/cpu/resetvec.S b/arch/x86/cpu/resetvec.S index 44aee5f..5b359ff 100644 --- a/arch/x86/cpu/resetvec.S +++ b/arch/x86/cpu/re

Re: [U-Boot] [PATCH 3/9] x86: Allow excluding reset handling code from u-boot.

2012-10-09 Thread Graeme Russ
Hi Simon, On Wed, Oct 10, 2012 at 8:15 AM, Simon Glass wrote: >>> diff --git a/arch/x86/cpu/resetvec.S b/arch/x86/cpu/resetvec.S >>> index 44aee5f..5b359ff 100644 >>> --- a/arch/x86/cpu/resetvec.S >>> +++ b/arch/x86/cpu/resetvec.S >>> @@ -25,6 +25,10 @@ >>> >>> /* Reset vector, jumps to start16

Re: [U-Boot] [PATCH 3/9] x86: Allow excluding reset handling code from u-boot.

2012-10-09 Thread Simon Glass
Hi Graeme, On Wed, Oct 3, 2012 at 6:01 PM, Graeme Russ wrote: > Hi Simon, > > At first I thought this patch dealt with the 'board reset' code but > then realised it deals with the 'reset vector' - Can you fix the patch > subject please Will do. > > On Thu, Oct 4, 2012 at 10:39 AM, Simon Glass

Re: [U-Boot] [PATCH 3/9] x86: Allow excluding reset handling code from u-boot.

2012-10-03 Thread Graeme Russ
Hi Simon, At first I thought this patch dealt with the 'board reset' code but then realised it deals with the 'reset vector' - Can you fix the patch subject please On Thu, Oct 4, 2012 at 10:39 AM, Simon Glass wrote: > From: Gabe Black > > When running from coreboot we don't want this code. > >

[U-Boot] [PATCH 3/9] x86: Allow excluding reset handling code from u-boot.

2012-10-03 Thread Simon Glass
From: Gabe Black When running from coreboot we don't want this code. This version works by ifdef-ing out all of the code that would go into those sections and all the code that refers to it. The sections are then empty, and the linker will either leave them empty for the loader to ignore or remo