Re: [U-Boot] [PATCH 3/8] ARMV7: Modify i2c driver for more reliable operation on OMAP4

2010-07-23 Thread Nishanth Menon
On Fri, Jul 23, 2010 at 11:33 AM, Steve Sakoman wrote: > On Wed, Jul 21, 2010 at 4:53 PM, Nishanth Menon > wrote: > > diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c > index 3256133..a91fe55 100644 > --- a/drivers/i2c/omap24xx_i2c.c > +++ b/drivers/i2c/omap24x

Re: [U-Boot] [PATCH 3/8] ARMV7: Modify i2c driver for more reliable operation on OMAP4

2010-07-23 Thread Steve Sakoman
On Wed, Jul 21, 2010 at 4:53 PM, Nishanth Menon wrote: diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c index 3256133..a91fe55 100644 --- a/drivers/i2c/omap24xx_i2c.c +++ b/drivers/i2c/omap24xx_i2c.c @@ -41,6 +41,7 @@ void i2c_init (int speed, int slav

Re: [U-Boot] [PATCH 3/8] ARMV7: Modify i2c driver for more reliable operation on OMAP4

2010-07-21 Thread Nishanth Menon
On 07/21/2010 06:41 PM, Steve Sakoman wrote: > On Wed, Jul 21, 2010 at 4:22 PM, Nishanth Menon > wrote: >> Steve, >> just minor nitpick below: >> >> On 07/21/2010 02:25 PM, Steve Sakoman wrote: >>> In addition to modifying the init routine to follow the TRM >>> recommendations, this patch adds a

Re: [U-Boot] [PATCH 3/8] ARMV7: Modify i2c driver for more reliable operation on OMAP4

2010-07-21 Thread Steve Sakoman
On Wed, Jul 21, 2010 at 4:22 PM, Nishanth Menon wrote: > Steve, > just minor nitpick below: > > On 07/21/2010 02:25 PM, Steve Sakoman wrote: >> In addition to modifying the init routine to follow the TRM >> recommendations, this patch adds a retry count to two loops >> to avoid the possibility of

Re: [U-Boot] [PATCH 3/8] ARMV7: Modify i2c driver for more reliable operation on OMAP4

2010-07-21 Thread Nishanth Menon
Steve, just minor nitpick below: On 07/21/2010 02:25 PM, Steve Sakoman wrote: > In addition to modifying the init routine to follow the TRM > recommendations, this patch adds a retry count to two loops > to avoid the possibility of infinite loops. It also corrects > error message typos in the i2c

[U-Boot] [PATCH 3/8] ARMV7: Modify i2c driver for more reliable operation on OMAP4

2010-07-21 Thread Steve Sakoman
In addition to modifying the init routine to follow the TRM recommendations, this patch adds a retry count to two loops to avoid the possibility of infinite loops. It also corrects error message typos in the i2c_write routine. Signed-off-by: Steve Sakoman --- arch/arm/include/asm/arch-omap3/i2