Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-09-09 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201109082050.51313.vap...@gentoo.org> you wrote: > > > Could you _please_ accustom yourself to updating the status in > > patchwork to "changes requested" when sending revierw comments like > > here? > > be nice if patchwork itself would key off a tag we could use

Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-09-08 Thread Mike Frysinger
On Wednesday, September 07, 2011 17:10:03 Wolfgang Denk wrote: > Mike Frysinger wrote: > > NAK for a few reasons: > > - i dont see how this could possibly compile warning free > > - you never initialize "i", only added to it > > - you call va_start() inbetween variable decls > > Could you _plea

Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-09-07 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108311847.16042.vap...@gentoo.org> you wrote: > > NAK for a few reasons: > - i dont see how this could possibly compile warning free > - you never initialize "i", only added to it > - you call va_start() inbetween variable decls Could you _please_ accustom y

Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-08-31 Thread Andrew Murray
On 1 September 2011 00:38, Graeme Russ wrote: > Hi Mike, Andrew, > > On Thu, Sep 1, 2011 at 8:47 AM, Mike Frysinger wrote: >> On Wednesday, August 31, 2011 18:20:57 Andrew Murray wrote: >>>       va_list args; >>>       uint i; >>>       char printbuffer[CONFIG_SYS_PBSIZE]; >>> +     char *buf =

Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-08-31 Thread Graeme Russ
Hi Mike, Andrew, On Thu, Sep 1, 2011 at 8:47 AM, Mike Frysinger wrote: > On Wednesday, August 31, 2011 18:20:57 Andrew Murray wrote: >> va_list args; >> uint i; >> char printbuffer[CONFIG_SYS_PBSIZE]; >> + char *buf = printbuffer; >> >> va_start(args, fmt); >> >> +#if

Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-08-31 Thread Andrew Murray
On 31 August 2011 23:47, Mike Frysinger wrote: > On Wednesday, August 31, 2011 18:20:57 Andrew Murray wrote: >>       va_list args; >>       uint i; >>       char printbuffer[CONFIG_SYS_PBSIZE]; >> +     char *buf = printbuffer; >> >>       va_start(args, fmt); >> >> +#if defined(CONFIG_BOOT_TRACE

Re: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-08-31 Thread Mike Frysinger
On Wednesday, August 31, 2011 18:20:57 Andrew Murray wrote: > va_list args; > uint i; > char printbuffer[CONFIG_SYS_PBSIZE]; > + char *buf = printbuffer; > > va_start(args, fmt); > > +#if defined(CONFIG_BOOT_TRACE) > + unsigned long long ticks = get_ticks(); > +

[U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

2011-08-31 Thread Andrew Murray
From: Andrew Murray This patch adds timings information to printfs. Signed-off-by: Andrew Murray --- common/console.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/common/console.c b/common/console.c index 8c650e0..33de3fa 100644 --- a/common/console.c ++