Re: [U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local

2012-09-02 Thread Wolfgang Denk
Dear Marek Vasut, In message <201209020202.51744.ma...@denx.de> you wrote: > Dear Andreas Bießmann, > > > Dear Marek Vasut, > > Heh, this Dear $recipient became really popular :-) If somebody can recommend a more clever rule than "%(friendly {from})" for my nmh replcomps file I would be all too h

Re: [U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local

2012-09-01 Thread Marek Vasut
Dear Andreas Bießmann, > Dear Marek Vasut, Heh, this Dear $recipient became really popular :-) [...] > return is not required here .. > > > } > > > > static inline void console_puts(int file, const char *s) > > { > > > > - stdio_devices[file]->puts(s); > > + struct stdio_dev *dev = s

Re: [U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local

2012-09-01 Thread Andreas Bießmann
Dear Marek Vasut, On 01.09.12 00:44, Marek Vasut wrote: > Use stdio_get_fd() and stdio_set_fd() instead of direct access > to the array. This allows making stdio_devices[] local to stdio.c > > Signed-off-by: Marek Vasut > Cc: Wolfgang Denk > --- > common/cmd_console.c |8 +++ > common

Re: [U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local

2012-09-01 Thread Marek Vasut
Dear Marek Vasut, > Use stdio_get_fd() and stdio_set_fd() instead of direct access > to the array. This allows making stdio_devices[] local to stdio.c > > Signed-off-by: Marek Vasut > Cc: Wolfgang Denk [...] > @@ -622,6 +635,7 @@ int console_init_r(void) > { > char *stdinname, *stdoutn

[U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local

2012-08-31 Thread Marek Vasut
Use stdio_get_fd() and stdio_set_fd() instead of direct access to the array. This allows making stdio_devices[] local to stdio.c Signed-off-by: Marek Vasut Cc: Wolfgang Denk --- common/cmd_console.c |8 +++ common/cmd_terminal.c |9 ++-- common/console.c | 60 +++