Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-27 Thread Marek Vasut
Dear Allen Martin, > On Fri, Oct 26, 2012 at 11:39:48AM -0700, Joe Hershberger wrote: > > Hi Marek, > > > > On Fri, Oct 26, 2012 at 5:22 AM, Marek Vasut wrote: > > > Dear Joe Hershberger, > > > > > >> Hi Allen, > > >> > > >> On Thu, Oct 25, 2012 at 4:19 PM, Allen Martin wrote: > > >> > On Thu

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-26 Thread Allen Martin
On Fri, Oct 26, 2012 at 11:39:48AM -0700, Joe Hershberger wrote: > Hi Marek, > > On Fri, Oct 26, 2012 at 5:22 AM, Marek Vasut wrote: > > Dear Joe Hershberger, > > > >> Hi Allen, > >> > >> On Thu, Oct 25, 2012 at 4:19 PM, Allen Martin wrote: > >> > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-26 Thread Joe Hershberger
Hi Marek, On Fri, Oct 26, 2012 at 5:22 AM, Marek Vasut wrote: > Dear Joe Hershberger, > >> Hi Allen, >> >> On Thu, Oct 25, 2012 at 4:19 PM, Allen Martin wrote: >> > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: >> >> Hi, >> >> >> >> On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut w

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-26 Thread Allen Martin
On Fri, Oct 26, 2012 at 03:22:32AM -0700, Marek Vasut wrote: > Dear Joe Hershberger, > > > Hi Allen, > > > > On Thu, Oct 25, 2012 at 4:19 PM, Allen Martin wrote: > > > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: > > >> Hi, > > >> > > >> On Thu, Oct 25, 2012 at 12:03 PM, Marek V

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-26 Thread Marek Vasut
Dear Joe Hershberger, > Hi Allen, > > On Thu, Oct 25, 2012 at 4:19 PM, Allen Martin wrote: > > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: > >> Hi, > >> > >> On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut wrote: > >> > Dear Simon Glass, > >> > > >> >> Hi, > >> >> > >> >> On M

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Joe Hershberger
Hi Allen, On Thu, Oct 25, 2012 at 4:19 PM, Allen Martin wrote: > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: >> Hi, >> >> On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut wrote: >> > Dear Simon Glass, >> > >> >> Hi, >> >> >> >> On Mon, Oct 22, 2012 at 10:23 AM, Allen Martin wrote:

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Allen Martin
On Thu, Oct 25, 2012 at 02:27:24PM -0700, Tom Rini wrote: > * PGP Signed by an unknown key > > On 10/25/12 14:19, Allen Martin wrote: > > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: > >> Hi, > >> > >> On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut > >> wrote: > >>> Dear Simon Gl

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/25/12 14:19, Allen Martin wrote: > On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: >> Hi, >> >> On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut >> wrote: >>> Dear Simon Glass, >>> Hi, On Mon, Oct 22, 2012 at 10:23 A

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Allen Martin
On Thu, Oct 25, 2012 at 02:02:55PM -0700, Simon Glass wrote: > Hi, > > On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut wrote: > > Dear Simon Glass, > > > >> Hi, > >> > >> On Mon, Oct 22, 2012 at 10:23 AM, Allen Martin wrote: > >> > On Sat, Oct 20, 2012 at 01:19:00AM -0700, Marek Vasut wrote: > >>

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Simon Glass
Hi, On Thu, Oct 25, 2012 at 12:03 PM, Marek Vasut wrote: > Dear Simon Glass, > >> Hi, >> >> On Mon, Oct 22, 2012 at 10:23 AM, Allen Martin wrote: >> > On Sat, Oct 20, 2012 at 01:19:00AM -0700, Marek Vasut wrote: >> >> Dear Allen Martin, >> >> >> >> [...] >> >> >> >> > Hi Marek, the change to ret

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Allen Martin
On Thu, Oct 25, 2012 at 12:03:47PM -0700, Marek Vasut wrote: > Dear Simon Glass, > > > Hi, > > > > On Mon, Oct 22, 2012 at 10:23 AM, Allen Martin wrote: > > > On Sat, Oct 20, 2012 at 01:19:00AM -0700, Marek Vasut wrote: > > >> Dear Allen Martin, > > >> > > >> [...] > > >> > > >> > Hi Marek, th

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Marek Vasut
Dear Simon Glass, > Hi, > > On Mon, Oct 22, 2012 at 10:23 AM, Allen Martin wrote: > > On Sat, Oct 20, 2012 at 01:19:00AM -0700, Marek Vasut wrote: > >> Dear Allen Martin, > >> > >> [...] > >> > >> > Hi Marek, the change to return value here broke serial output on > >> > tegra. What I see is t

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-25 Thread Simon Glass
Hi, On Mon, Oct 22, 2012 at 10:23 AM, Allen Martin wrote: > On Sat, Oct 20, 2012 at 01:19:00AM -0700, Marek Vasut wrote: >> Dear Allen Martin, >> >> [...] >> > >> > Hi Marek, the change to return value here broke serial output on >> > tegra. What I see is that the serial device name (s->name) is

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-22 Thread Allen Martin
On Sat, Oct 20, 2012 at 01:19:00AM -0700, Marek Vasut wrote: > Dear Allen Martin, > > [...] > > > > Hi Marek, the change to return value here broke serial output on > > tegra. What I see is that the serial device name (s->name) is > > "eserial0" as set by serial_ns16550.c, and the name passed in

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-20 Thread Marek Vasut
Dear Allen Martin, [...] > > Hi Marek, the change to return value here broke serial output on > tegra. What I see is that the serial device name (s->name) is > "eserial0" as set by serial_ns16550.c, and the name passed in from the > stdout environment is "serial" so they don't match and it fails

Re: [U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-19 Thread Allen Martin
On Sat, Oct 06, 2012 at 05:07:03PM -0700, Marek Vasut wrote: > Reorder serial_assign() function to get rid of the extra level of > indentation. Also, adjust the return value to be -EINVAL instead of > positive one to be more consistent. > > Signed-off-by: Marek Vasut > Cc: Marek Vasut > Cc: Tom

[U-Boot] [PATCH 3/6] serial: Reorder serial_assign()

2012-10-06 Thread Marek Vasut
Reorder serial_assign() function to get rid of the extra level of indentation. Also, adjust the return value to be -EINVAL instead of positive one to be more consistent. Signed-off-by: Marek Vasut Cc: Marek Vasut Cc: Tom Rini --- drivers/serial/serial.c | 11 ++- 1 file changed, 6 in