Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-08 Thread Scott Wood
On Tue, 2016-06-07 at 07:41 +0200, Boris Brezillon wrote: > On Mon, 06 Jun 2016 18:54:03 -0500 > Scott Wood wrote: > > > Of course the driver model > > is probably the long-term solution. > > Definitely, and talking about things that need to be reworked, do you > know why u-boot is using its own

Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Boris Brezillon
On Mon, 06 Jun 2016 18:54:03 -0500 Scott Wood wrote: > On Mon, 2016-06-06 at 20:31 +0200, Boris Brezillon wrote: > > On Mon, 06 Jun 2016 12:56:48 -0500 > > Scott Wood wrote: > > > > > On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote: > > > > On Mon, 6 Jun 2016 17:36:10 +0200 > > > >

Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Scott Wood
On Mon, 2016-06-06 at 20:31 +0200, Boris Brezillon wrote: > On Mon, 06 Jun 2016 12:56:48 -0500 > Scott Wood wrote: > > > On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote: > > > On Mon, 6 Jun 2016 17:36:10 +0200 > > > Hans de Goede wrote: > > > > > > > > +#ifndef CONFIG_SPL_BUILD > > >

Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Boris Brezillon
On Mon, 06 Jun 2016 12:56:48 -0500 Scott Wood wrote: > On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote: > > On Mon, 6 Jun 2016 17:36:10 +0200 > > Hans de Goede wrote: > > > > > > +#ifndef CONFIG_SPL_BUILD > > > > +void sunxi_nand_init(void); > > > > +#endif > > > > + > > > > > >

Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Scott Wood
On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote: > On Mon, 6 Jun 2016 17:36:10 +0200 > Hans de Goede wrote: > > > > +#ifndef CONFIG_SPL_BUILD > > > +void sunxi_nand_init(void); > > > +#endif > > > + > > > > Can we have this in a header somewhere please, and without > > the #ifdef arou

Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Boris Brezillon
On Mon, 6 Jun 2016 17:36:10 +0200 Hans de Goede wrote: > > +#ifndef CONFIG_SPL_BUILD > > +void sunxi_nand_init(void); > > +#endif > > + > > Can we have this in a header somewhere please, and without > the #ifdef around it, that is not necessary for prototypes. Hehe, I was expecting this one :

Re: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Hans de Goede
Hi, One small remark inline. On 06-06-16 17:21, Boris Brezillon wrote: We already have an SPL driver for the sunxi NAND controller, now add the normal/standard one. The source has been copied from Linux 4.6 with a few changes to make it work in u-boot. Signed-off-by: Boris Brezillon --- boa

[U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Boris Brezillon
We already have an SPL driver for the sunxi NAND controller, now add the normal/standard one. The source has been copied from Linux 4.6 with a few changes to make it work in u-boot. Signed-off-by: Boris Brezillon --- board/sunxi/board.c|9 +- drivers/mtd/nand/Kconfig |