Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-25 Thread Stefan Roese
On 08/24/2012 09:15 PM, Tom Rini wrote: >>> I still would like to move to my suggestion to not copy the header and >>> use the mkimage header values ih_load and ih_ep directly. Right now I >>> don't see any showstopper for doing it this way. I'll send a patch to >>> change this shortly (if everythi

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Daniel Schwierzeck
2012/8/24 Stefan Roese : > On 08/24/2012 06:42 PM, Daniel Schwierzeck wrote: > The u-boot image is merged with SPL > image without any padding or > fixed flash offsets to achieve a maximum reduction of flash footprint. Interesting. I'm still padding to the fixed offset. Let me

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Tom Rini
On 08/24/2012 04:13 AM, Stefan Roese wrote: > On 08/24/2012 12:56 PM, Stefan Roese wrote: >> I still would like to move to my suggestion to not copy the header and >> use the mkimage header values ih_load and ih_ep directly. Right now I >> don't see any showstopper for doing it this way. I'll send

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
On 08/24/2012 06:42 PM, Daniel Schwierzeck wrote: The u-boot image is merged with SPL image without any padding or fixed flash offsets to achieve a maximum reduction of flash footprint. >>> >>> Interesting. I'm still padding to the fixed offset. Let me look into >>> squeezing those t

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
On 08/24/2012 06:19 PM, Tom Rini wrote: What do you think? Can you move this gd init stuff into such a common ARM spl file in the next patchset version? >>> >>> Yes. We should probably say it's the job of board_init_f. I know full >>> U-Boot does it at the start of board_init_r but I th

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Daniel Schwierzeck
Hi Stefan, 2012/8/24 Stefan Roese : > Hi Daniel, > > On 08/24/2012 04:11 PM, Stefan Roese wrote: >>> The u-boot image is merged with SPL >>> image without any padding or >>> fixed flash offsets to achieve a maximum reduction of flash footprint. >> >> Interesting. I'm still padding to the fixed off

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Tom Rini
On 08/24/2012 09:07 AM, Stefan Roese wrote: > On 08/24/2012 05:55 PM, Tom Rini wrote: So, here's what I don't understand. On ARM, in general, we can't rely on the global data pointer register (r8) to be set to a useful value, so we do the above to ensure it points to something usefu

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
On 08/24/2012 05:55 PM, Tom Rini wrote: >>> So, here's what I don't understand. On ARM, in general, we can't rely >>> on the global data pointer register (r8) to be set to a useful value, so >>> we do the above to ensure it points to something useful. Are you always >>> able to rely on r2 it look

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
Hi Daniel, On 08/24/2012 04:11 PM, Stefan Roese wrote: >> The u-boot image is merged with SPL >> image without any padding or >> fixed flash offsets to achieve a maximum reduction of flash footprint. > > Interesting. I'm still padding to the fixed offset. Let me look into > squeezing those two im

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Tom Rini
On 08/24/2012 12:01 AM, Stefan Roese wrote: > Hi Tom, > > On 08/23/2012 11:39 PM, Tom Rini wrote: >> On 08/23/2012 01:12 AM, Stefan Roese wrote: >> >>> This patch enables the SPL framework to be used on powerpc platforms >>> and not only ARM. >> [snip] >>> +#ifdef CONFIG_ARM >>> gd = &gdata; >

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Daniel Schwierzeck
Hi Stefan, 2012/8/24 Stefan Roese : > Hi Daniel, > > On 08/24/2012 01:49 PM, Daniel Schwierzeck wrote: I still would like to move to my suggestion to not copy the header and use the mkimage header values ih_load and ih_ep directly. Right now I don't see any showstopper for doing it

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
Hi Daniel, On 08/24/2012 01:49 PM, Daniel Schwierzeck wrote: >>> I still would like to move to my suggestion to not copy the header and >>> use the mkimage header values ih_load and ih_ep directly. Right now I >>> don't see any showstopper for doing it this way. I'll send a patch to >>> change thi

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Daniel Schwierzeck
Hi Stefan, 2012/8/24 Stefan Roese : > On 08/24/2012 12:56 PM, Stefan Roese wrote: >> I still would like to move to my suggestion to not copy the header and >> use the mkimage header values ih_load and ih_ep directly. Right now I >> don't see any showstopper for doing it this way. I'll send a patch

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
On 08/24/2012 12:56 PM, Stefan Roese wrote: > I still would like to move to my suggestion to not copy the header and > use the mkimage header values ih_load and ih_ep directly. Right now I > don't see any showstopper for doing it this way. I'll send a patch to > change this shortly (if everything w

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
Hi Heiko, On 08/24/2012 12:17 PM, Heiko Schocher wrote: >> BTW: There also seems to be a bug in some of the SPL loaders: >> >> For example in drivers/mtd/nand/nand_spl_load.c: >> >> ... >> if (header->ih_os == IH_OS_LINUX) { >> /* happy - was a linux

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Heiko Schocher
Hello Stefan On 24.08.2012 10:17, Stefan Roese wrote: Hi Tom, On 08/23/2012 09:31 PM, Tom Rini wrote: @@ -89,7 +106,11 @@ void spl_parse_image_header(const struct image_header *header) spl_image.size = __be32_to_cpu(header->ih_size) + header_size; spl_image.ent

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
Hi Tom, On 08/23/2012 09:31 PM, Tom Rini wrote: @@ -89,7 +106,11 @@ void spl_parse_image_header(const struct image_header *header) spl_image.size = __be32_to_cpu(header->ih_size) + header_size; spl_image.entry_point = __be32_to_cpu(header->ih_load);

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
Hi Tom, On 08/23/2012 11:52 PM, Tom Rini wrote: > On 08/23/2012 01:12 AM, Stefan Roese wrote: > >> This patch enables the SPL framework to be used on powerpc platforms >> and not only ARM. > [snip] >> +#ifdef CONFIG_PPC >> +static void __noreturn jump_to_image_linux(void *arg) >> +{ >> +debug

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-24 Thread Stefan Roese
Hi Tom, On 08/23/2012 11:39 PM, Tom Rini wrote: > On 08/23/2012 01:12 AM, Stefan Roese wrote: > >> This patch enables the SPL framework to be used on powerpc platforms >> and not only ARM. > [snip] >> +#ifdef CONFIG_ARM >> gd = &gdata; >> +#endif > > So, here's what I don't understand. On

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-23 Thread Tom Rini
On 08/23/2012 01:12 AM, Stefan Roese wrote: > This patch enables the SPL framework to be used on powerpc platforms > and not only ARM. [snip] > +#ifdef CONFIG_PPC > +static void __noreturn jump_to_image_linux(void *arg) > +{ > + debug("Entering kernel arg pointer: 0x%p\n", arg); > + typede

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-23 Thread Tom Rini
On 08/23/2012 01:12 AM, Stefan Roese wrote: > This patch enables the SPL framework to be used on powerpc platforms > and not only ARM. [snip] > +#ifdef CONFIG_ARM > gd = &gdata; > +#endif So, here's what I don't understand. On ARM, in general, we can't rely on the global data pointer regis

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-23 Thread Tom Rini
On 08/23/2012 11:16 AM, Stefan Roese wrote: > On 08/23/2012 07:10 PM, Tom Rini wrote: >>> +#ifdef CONFIG_ARM >>> /* Define global data structure pointer to it*/ >>> gd_t gdata __attribute__ ((section(".data"))); >>> +#endif >> >> So you handle cleaning up the BSS differently, interesting. I'm go

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-23 Thread Stefan Roese
On 08/23/2012 07:10 PM, Tom Rini wrote: >> +#ifdef CONFIG_ARM >> /* Define global data structure pointer to it*/ >> gd_t gdata __attribute__ ((section(".data"))); >> +#endif > > So you handle cleaning up the BSS differently, interesting. I'm going > to see if that would work for ARM too.. Yes.

Re: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-23 Thread Tom Rini
On 08/23/2012 01:12 AM, Stefan Roese wrote: > This patch enables the SPL framework to be used on powerpc platforms > and not only ARM. [snip] > +#ifdef CONFIG_ARM > /* Define global data structure pointer to it*/ > gd_t gdata __attribute__ ((section(".data"))); > +#endif So you handle cleaning

[U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc

2012-08-23 Thread Stefan Roese
This patch enables the SPL framework to be used on powerpc platforms and not only ARM. Signed-off-by: Stefan Roese --- common/spl/spl.c | 45 ++--- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 4c0