Re: [U-Boot] [PATCH 3/5] ixp: move pci init in arm/board instead of cpu

2009-01-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:41 Thu 22 Jan , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090122081513.ga15...@game.jcrosoft.org> you wrote: > > > > > > + pci_init(); > > > > + return 0; > > > > +} > > > > > > Maybe pci_init() should return some error code? > > no it d

Re: [U-Boot] [PATCH 3/5] ixp: move pci init in arm/board instead of cpu

2009-01-22 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090122081513.ga15...@game.jcrosoft.org> you wrote: > > > > + pci_init(); > > > + return 0; > > > +} > > > > Maybe pci_init() should return some error code? > no it does not I am aware that it doesn't. I wrote: "It *should* return some error c

Re: [U-Boot] [PATCH 3/5] ixp: move pci init in arm/board instead of cpu

2009-01-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:51 Thu 22 Jan , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <1232604438-15471-4-git-send-email-plagn...@jcrosoft.com> you > wrote: > > > > +#if defined(CONFIG_CMD_PCI) || defined (CONFIG_PCI) > > +#include > > +static int arm_pci_init(void) > > +{ > >

Re: [U-Boot] [PATCH 3/5] ixp: move pci init in arm/board instead of cpu

2009-01-21 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <1232604438-15471-4-git-send-email-plagn...@jcrosoft.com> you wrote: > > +#if defined(CONFIG_CMD_PCI) || defined (CONFIG_PCI) > +#include > +static int arm_pci_init(void) > +{ > + pci_init(); > + return 0; > +} Maybe pci_init() should re

[U-Boot] [PATCH 3/5] ixp: move pci init in arm/board instead of cpu

2009-01-21 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD diff --git a/cpu/ixp/cpu.c b/cpu/ixp/cpu.c index 27872fb..fd545b5 100644 --- a/cpu/ixp/cpu.c +++ b/cpu/ixp/cpu.c @@ -86,9 +86,6 @@ int cpu_init (void) FIQ_STACK_START = IRQ_STACK_START - CONFIG_STACKSIZE_IRQ; #endif -#if defined(CONFIG_CM