Re: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-30 Thread Troy Kisky
On 1/30/2012 5:05 PM, Andy Fleming wrote: On Mon, Jan 30, 2012 at 3:30 PM, Troy Kisky wrote: On 1/29/2012 7:26 PM, Andy Fleming wrote: NAK, for reasons listed below. An earlier version of something like PHY Lib had a similar type of mechanism, but a list of register writes is often insuffici

Re: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-30 Thread Andy Fleming
On Mon, Jan 30, 2012 at 3:30 PM, Troy Kisky wrote: > On 1/29/2012 7:26 PM, Andy Fleming wrote: >> >> NAK, for reasons listed below. >> >> An earlier version of something like PHY Lib had a similar type of >> mechanism, but a list of register writes is often insufficient to the >> task of performin

Re: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-30 Thread Troy Kisky
On 1/29/2012 7:26 PM, Andy Fleming wrote: NAK, for reasons listed below. On Thu, Jan 26, 2012 at 4:21 PM, Troy Kisky wrote: Add the gigabit phy KSZ9021. Signed-off-by: Troy Kisky These commit messages are a bit over-brief. Please explain a bit more if there's anything non-trivial in the pat

Re: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-29 Thread Andy Fleming
NAK, for reasons listed below. On Thu, Jan 26, 2012 at 4:21 PM, Troy Kisky wrote: > Add the gigabit phy KSZ9021. > > Signed-off-by: Troy Kisky These commit messages are a bit over-brief. Please explain a bit more if there's anything non-trivial in the patch. > --- >  drivers/net/phy/Makefile

Re: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-27 Thread Troy Kisky
On 1/26/2012 7:54 PM, Mike Frysinger wrote: On Thursday 26 January 2012 17:21:44 Troy Kisky wrote: +/* This is used to set board specific things like clock skew */ +unsigned short ksz9021_por_cmds[] = { static const Thanks +int ksz9021_send_phy_cmds(struct phy_device *phydev, unsigned shor

Re: [U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-26 Thread Mike Frysinger
On Thursday 26 January 2012 17:21:44 Troy Kisky wrote: > +/* This is used to set board specific things like clock skew */ > +unsigned short ksz9021_por_cmds[] = { static const > +int ksz9021_send_phy_cmds(struct phy_device *phydev, unsigned short* p) static > + for (;;) { personally, i'd p

[U-Boot] [PATCH 3/4] net: phy: add support for Micrel's KSZ9021

2012-01-26 Thread Troy Kisky
Add the gigabit phy KSZ9021. Signed-off-by: Troy Kisky --- drivers/net/phy/Makefile |1 + drivers/net/phy/micrel_ksz9021.c | 124 ++ drivers/net/phy/phy.c|3 + 3 files changed, 128 insertions(+), 0 deletions(-) create mode 100644