Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Simon Glass
Hi Bin, On 3 January 2015 at 20:41, Bin Meng wrote: > Hi Simon, > > On Sun, Jan 4, 2015 at 11:19 AM, Simon Glass wrote: >> Hi Bin, >> >> On 3 January 2015 at 20:12, Bin Meng wrote: >>> Hi Simon, >>> >>> On Sun, Jan 4, 2015 at 11:01 AM, Simon Glass wrote: Hi Bin, On 3 January 201

Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Bin Meng
Hi Simon, On Sun, Jan 4, 2015 at 11:19 AM, Simon Glass wrote: > Hi Bin, > > On 3 January 2015 at 20:12, Bin Meng wrote: >> Hi Simon, >> >> On Sun, Jan 4, 2015 at 11:01 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 3 January 2015 at 19:58, Bin Meng wrote: Hi Simon, On Sun, Jan 4,

Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Simon Glass
Hi Bin, On 3 January 2015 at 20:12, Bin Meng wrote: > Hi Simon, > > On Sun, Jan 4, 2015 at 11:01 AM, Simon Glass wrote: >> Hi Bin, >> >> On 3 January 2015 at 19:58, Bin Meng wrote: >>> Hi Simon, >>> >>> On Sun, Jan 4, 2015 at 10:33 AM, Simon Glass wrote: Hi Bin, On 3 January 201

Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Bin Meng
Hi Simon, On Sun, Jan 4, 2015 at 11:01 AM, Simon Glass wrote: > Hi Bin, > > On 3 January 2015 at 19:58, Bin Meng wrote: >> Hi Simon, >> >> On Sun, Jan 4, 2015 at 10:33 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 3 January 2015 at 07:40, Bin Meng wrote: cros_ec_board_init() should be cal

Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Simon Glass
Hi Bin, On 3 January 2015 at 19:58, Bin Meng wrote: > Hi Simon, > > On Sun, Jan 4, 2015 at 10:33 AM, Simon Glass wrote: >> Hi Bin, >> >> On 3 January 2015 at 07:40, Bin Meng wrote: >>> cros_ec_board_init() should be called only when CONFIG_CROS_EC is >>> enabled. Also undef CONFIG_CROS_EC in th

Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Bin Meng
Hi Simon, On Sun, Jan 4, 2015 at 10:33 AM, Simon Glass wrote: > Hi Bin, > > On 3 January 2015 at 07:40, Bin Meng wrote: >> cros_ec_board_init() should be called only when CONFIG_CROS_EC is >> enabled. Also undef CONFIG_CROS_EC in the coreboot configuration. >> >> Signed-off-by: Bin Meng >> >> -

Re: [U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Simon Glass
Hi Bin, On 3 January 2015 at 07:40, Bin Meng wrote: > cros_ec_board_init() should be called only when CONFIG_CROS_EC is > enabled. Also undef CONFIG_CROS_EC in the coreboot configuration. > > Signed-off-by: Bin Meng > > --- > > board/coreboot/coreboot/coreboot.c | 2 ++ > include/configs/corebo

[U-Boot] [PATCH 3/3] x86: coreboot: Wrap cros_ec initialization

2015-01-03 Thread Bin Meng
cros_ec_board_init() should be called only when CONFIG_CROS_EC is enabled. Also undef CONFIG_CROS_EC in the coreboot configuration. Signed-off-by: Bin Meng --- board/coreboot/coreboot/coreboot.c | 2 ++ include/configs/coreboot.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-