Re: [U-Boot] [PATCH 3/3] usb: gadget: fastboot: terminate commands with NULL

2014-10-01 Thread Eric Nelson
Thanks Steve, On 10/01/2014 01:40 PM, Steve Rae wrote: > > > On 14-09-30 12:05 PM, Eric Nelson wrote: >> Without NULL termination, various commands will read past the >> end of input. In particular, this was noticed with error() >> calls in cb_getvar and simple_strtoul() in cb_download. >> >> Si

Re: [U-Boot] [PATCH 3/3] usb: gadget: fastboot: terminate commands with NULL

2014-10-01 Thread Steve Rae
On 14-09-30 12:05 PM, Eric Nelson wrote: Without NULL termination, various commands will read past the end of input. In particular, this was noticed with error() calls in cb_getvar and simple_strtoul() in cb_download. Since the download callback happens elsewhere, the 4k buffer should always b

[U-Boot] [PATCH 3/3] usb: gadget: fastboot: terminate commands with NULL

2014-09-30 Thread Eric Nelson
Without NULL termination, various commands will read past the end of input. In particular, this was noticed with error() calls in cb_getvar and simple_strtoul() in cb_download. Since the download callback happens elsewhere, the 4k buffer should always be sufficient to handle command arguments. Si