Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-21 Thread Masahiro Yamada
Hello Albert. > > The way the code is written now, board_by_field() has to do the job of > board_by_cpu() and has to know the CPU field has colon-separated > subfields. What should be done is, board_by_field should not even worry > about colons at all, and it is board_by_cpu() which should know

Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Masahiro Yamada
Hello Albert. > The way the code is written now, board_by_field() has to do the job of > board_by_cpu() and has to know the CPU field has colon-separated > subfields. What should be done is, board_by_field should not even worry > about colons at all, and it is board_by_cpu() which should know ab

Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Albert ARIBAUD
Hi Masahiro, On Thu, 17 Oct 2013 19:32:31 +0900, Masahiro Yamada wrote: > Hello Albert > > > > > > > -v field="$1" \ > > > -v select="$2" \ > > > -F "$FS" \ > > > - '($1 !~ /^#/ && $field == select) { print $1 }' \

Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Masahiro Yamada
Hello Albert > > -v field="$1" \ > > -v select="$2" \ > > -F "$FS" \ > > - '($1 !~ /^#/ && $field == select) { print $1 }' \ > > + '($1 !~ /^#/ && $field == select) { print $7 }' \ > >

Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Albert ARIBAUD
Hi Masahiro, On Thu, 17 Oct 2013 16:37:42 +0900, Masahiro Yamada wrote: > Commit 27af930e changed the boards.cfg format > and it changed boards_by_field() function incorrectly. > For tegra cpus it returned Board Name field, > not Target field. > > Signed-off-by: Masahiro Yamada > Cc: Albert AR

Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Masahiro Yamada
Hello Albert. > > Commit 27af930e adjusted this part like follows: > > > > > > -v field="$1" \ > > -v select="$2" \ > > -F "$FS" \ > > - '($1 !~ /^#/ && $field == select) { print $1 }' \ > > + '($1 !

Re: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Albert ARIBAUD
Hi Masahiro, On Thu, 17 Oct 2013 16:37:42 +0900, Masahiro Yamada wrote: > Commit 27af930e changed the boards.cfg format > and it changed boards_by_field() function incorrectly. > For tegra cpus it returned Board Name field, > not Target field. > > Signed-off-by: Masahiro Yamada > Cc: Albert AR

[U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function

2013-10-17 Thread Masahiro Yamada
Commit 27af930e changed the boards.cfg format and it changed boards_by_field() function incorrectly. For tegra cpus it returned Board Name field, not Target field. Signed-off-by: Masahiro Yamada Cc: Albert ARIBAUD --- Commit 27af930e adjusted this part like follows: -v fie