Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-28 Thread Tuomas Tynkkynen
On 27/08/14 17:34, Thierry Reding wrote: [...] >>> On my board, this call results in UART corruption, like this: >>> >>> tegra-pcie: non-prefetchable memory: 0x1300-0x2000 >>> tegra-pcie: prefetchable memory: 0x2000-0x4000 >>> ¥É½¥¹½bªÍ¥¹b2x1, 1x1 configuration >>> ¹Í5Rþtegra-

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-27 Thread Thierry Reding
On Wed, Aug 27, 2014 at 03:28:06PM +0200, Thierry Reding wrote: > On Tue, Aug 26, 2014 at 03:54:50PM +0300, Tuomas Tynkkynen wrote: > > On 18/08/14 10:16, Thierry Reding wrote: > > [...] > > > +static int as3722_gpio_direction_output(u8 gpio, u8 level) > > > +{ > > > + u8 value; > > > + int err; >

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-27 Thread Thierry Reding
On Tue, Aug 26, 2014 at 03:54:50PM +0300, Tuomas Tynkkynen wrote: > On 18/08/14 10:16, Thierry Reding wrote: > [...] > > +static int as3722_gpio_direction_output(u8 gpio, u8 level) > > +{ > > + u8 value; > > + int err; > > + > > + if (gpio > 7) > > + return -EINVAL; > > + > > + if

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-27 Thread Tuomas Tynkkynen
On 18/08/14 10:16, Thierry Reding wrote: [...] > +static int as3722_gpio_direction_output(u8 gpio, u8 level) > +{ > + u8 value; > + int err; > + > + if (gpio > 7) > + return -EINVAL; > + > + if (level == 0) > + value = AS3722_GPIO_CONTROL_MODE_OUTPUT_VDDL; >

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-23 Thread Thierry Reding
On Fri, Aug 22, 2014 at 07:47:36PM -0600, Simon Glass wrote: > Hi Thierry, > > On 22 August 2014 16:03, Thierry Reding wrote: > > On Fri, Aug 22, 2014 at 02:12:19PM -0600, Simon Glass wrote: > >> On 22 August 2014 13:40, Thierry Reding wrote: > > [...] > >> > I've opted instead to provide an som

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Simon Glass
Hi Thierry, On 22 August 2014 16:03, Thierry Reding wrote: > On Fri, Aug 22, 2014 at 02:12:19PM -0600, Simon Glass wrote: >> On 22 August 2014 13:40, Thierry Reding wrote: > [...] >> > I've opted instead to provide an somewhat higher-level API that users >> > can call to set voltages on the regu

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Thierry Reding
On Fri, Aug 22, 2014 at 02:12:19PM -0600, Simon Glass wrote: > On 22 August 2014 13:40, Thierry Reding wrote: [...] > > I've opted instead to provide an somewhat higher-level API that users > > can call to set voltages on the regulators and enable them. > > But then this should use/extend the pmi

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Simon Glass
Hi Thierry, On 22 August 2014 13:40, Thierry Reding wrote: > On Fri, Aug 22, 2014 at 01:27:57PM -0600, Simon Glass wrote: >> On 22 August 2014 06:09, Thierry Reding wrote: > [...] >> > Note that I haven't turned the AS3722 support into a "PMIC" driver, >> > because the framework for that seems t

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Thierry Reding
On Fri, Aug 22, 2014 at 01:27:57PM -0600, Simon Glass wrote: > On 22 August 2014 06:09, Thierry Reding wrote: [...] > > Note that I haven't turned the AS3722 support into a "PMIC" driver, > > because the framework for that seems to be unusable. It doesn't seem to > > abstract away driver-specifics

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Simon Glass
Hi Thierry, On 22 August 2014 06:09, Thierry Reding wrote: > On Wed, Aug 20, 2014 at 12:51:35PM -0600, Stephen Warren wrote: > > On 08/18/2014 01:16 AM, Thierry Reding wrote: > > >From: Thierry Reding > > > > > >The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes > > >the se

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Stephen Warren
On 08/22/2014 06:09 AM, Thierry Reding wrote: On Wed, Aug 20, 2014 at 12:51:35PM -0600, Stephen Warren wrote: On 08/18/2014 01:16 AM, Thierry Reding wrote: From: Thierry Reding The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes the second root port to a miniPCIe slot. Ena

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-22 Thread Thierry Reding
On Wed, Aug 20, 2014 at 12:51:35PM -0600, Stephen Warren wrote: > On 08/18/2014 01:16 AM, Thierry Reding wrote: > >From: Thierry Reding > > > >The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes > >the second root port to a miniPCIe slot. Enable the PCIe controller and > > >di

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-20 Thread Stephen Warren
On 08/18/2014 01:16 AM, Thierry Reding wrote: From: Thierry Reding The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes the second root port to a miniPCIe slot. Enable the PCIe controller and the network driver to allow the device to boot over the network. diff --git a/arc

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-20 Thread Stephen Warren
On 08/18/2014 01:16 AM, Thierry Reding wrote: From: Thierry Reding The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes the second root port to a miniPCIe slot. Enable the PCIe controller and diff --git a/arch/arm/dts/tegra124-jetson-tk1.dts b/arch/arm/dts/tegra124-jetson

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-19 Thread Simon Glass
Hi Thierry, On 19 August 2014 06:29, Thierry Reding wrote: > On Mon, Aug 18, 2014 at 12:37:46PM -0600, Simon Glass wrote: >> Hi Thierry, >> >> On 18 August 2014 01:16, Thierry Reding wrote: >> > From: Thierry Reding >> > >> > The Jetson TK1 has an ethernet NIC connected to the PCIe bus and rout

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-19 Thread Thierry Reding
On Mon, Aug 18, 2014 at 12:37:46PM -0600, Simon Glass wrote: > Hi Thierry, > > On 18 August 2014 01:16, Thierry Reding wrote: > > From: Thierry Reding > > > > The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes > > the second root port to a miniPCIe slot. Enable the PCIe cont

Re: [U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-18 Thread Simon Glass
Hi Thierry, On 18 August 2014 01:16, Thierry Reding wrote: > From: Thierry Reding > > The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes > the second root port to a miniPCIe slot. Enable the PCIe controller and > the network driver to allow the device to boot over the networ

[U-Boot] [PATCH 23/23] ARM: tegra: Enable PCIe on Jetson TK1

2014-08-18 Thread Thierry Reding
From: Thierry Reding The Jetson TK1 has an ethernet NIC connected to the PCIe bus and routes the second root port to a miniPCIe slot. Enable the PCIe controller and the network driver to allow the device to boot over the network. Signed-off-by: Thierry Reding --- arch/arm/dts/tegra124-jetson-t