Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-19 Thread Wolfgang Denk
Dear Vipin Kumar, In message <83d1d72b0912182356u6b140b24g8ee1e97becc62...@mail.gmail.com> you wrote: > > >> >> + /* Assume that all sectors are unprotected by default */ > >> >> + for (i = 0; i < CONFIG_SYS_MAX_FLASH_SECT; i++) > >> >> + info->protect[i] = 0; > >> > > >> > U

Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-19 Thread Vipin Kumar
Hi Albert, > >>> Why don;t you protect sectors where the U-Bootimage and environment >>> are stored? >> >> Since the code is being developed for a development board, erasing and >> flashing the uboot is frequent. This is done only to save unprotect every >> time before erasing/flashing uboot > > Y

Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-19 Thread Albert ARIBAUD
Vipin Kumar a écrit : >> Why don;t you protect sectors where the U-Bootimage and environment >> are stored? > > Since the code is being developed for a development board, erasing and > flashing the uboot is frequent. This is done only to save unprotect every > time before erasing/flashing uboot

Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-18 Thread Vipin Kumar
Dear Wolfgang, > In message <83d1d72b0912182244yb303c6ai3b61d7b896020...@mail.gmail.com> you > wrote: >> >> >> +     switch (density) { >> >> +     case 0x10: >> >> +             info->size = 64 * 1024; >> >> +             info->sector_count = 2; >> >> +             break; >> >> +     case 0x11:

Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-18 Thread Wolfgang Denk
Dear Vipin Kumar, In message <83d1d72b0912182244yb303c6ai3b61d7b896020...@mail.gmail.com> you wrote: > > >> + switch (density) { > >> + case 0x10: > >> + info->size = 64 * 1024; > >> + info->sector_count = 2; > >> + break; > >> + case 0x11: > >> +

Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-18 Thread Vipin Kumar
Dear Wolfgang, >> Signed-off-by: Vipin > ... >> +static ulong flash_get_size(ulong base, int banknum) >> +{ >> +     flash_info_t *info = &flash_info[banknum]; >> +     unsigned int value = 0; >> +     unsigned int density = 0; > > remove useless initialization. Ok I will send out a fresh patchs

Re: [U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-16 Thread Wolfgang Denk
Dear Vipin KUMAR, In message <1260955110-5656-3-git-send-email-vipin.ku...@st.com> you wrote: > > Signed-off-by: Vipin ... > +static ulong flash_get_size(ulong base, int banknum) > +{ > + flash_info_t *info = &flash_info[banknum]; > + unsigned int value = 0; > + unsigned int density

[U-Boot] [PATCH 2/9] smi driver support for SPEAr SoCs

2009-12-16 Thread Vipin KUMAR
Signed-off-by: Vipin --- drivers/mtd/Makefile |1 + drivers/mtd/spr_smi.c| 548 ++ include/asm-arm/arch-spear/spr_smi.h | 112 +++ 3 files changed, 661 insertions(+), 0 deletions(-) mode change 100644 => 100755 drivers/mt