Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-29 Thread Marek Vasut
Dear Benoît Thébaudeau, > Dear Marek Vasut, > > On Sun, Jul 29, 2012 at 03:40:32 AM, Marek Vasut wrote: > > > On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote: > > > > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > > > > [...] > > > > > > > > > > > > > +

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-29 Thread Benoît Thébaudeau
Dear Marek Vasut, On Sun, Jul 29, 2012 at 03:40:32 AM, Marek Vasut wrote: > > On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote: > > > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > > > [...] > > > > > > > > > > > + token = (toggle << 31) | > > > > > > > +

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-28 Thread Marek Vasut
Dear Benoît Thébaudeau, > Dear Marek, > > On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote: > > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > > [...] > > > > > > > > > + token = (toggle << 31) | > > > > > > + (xfr_bytes << 16) | >

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-28 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 04:13:45 PM, Benoît Thébaudeau wrote: > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > [...] > > > > > + token = (toggle << 31) | > > > > > + (xfr_bytes << 16) | > > > > > + ((req =

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Marek Vasut
Dear Benoît Thébaudeau, > Dear Marek, > > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > > Do you think > > > using PAGE_SIZE from would be fine since these > > > 4096 are > > > nothing more than page sizes? > > > > Isn't that intel-specific? > > I don't know. The code does not sa

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Benoît Thébaudeau
Dear Marek, On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > Do you think > > using PAGE_SIZE from would be fine since these > > 4096 are > > nothing more than page sizes? > > Isn't that intel-specific? I don't know. The code does not say so. What is sure is that page sizes should be

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Marek Vasut
Dear Benoît Thébaudeau, [...] > > Ok, maybe you can please elaborate on this crazy calculation in here? > > Or somehow > > clarify it? Also, won't the macros in include/common.h help in a way? > > (like > > ROUND() etc). > > I have already posted a v2 for this specific patch (only 2/5) that does

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Benoît Thébaudeau
Dear Marek Vasut, On Fri, Jul 27, 2012 at 02:54:07 PM, Marek Vasut wrote: > > This patch takes advantage of the hardware EHCI qTD queuing > > mechanism to > > avoid software overhead and to make transfers as fast as possible. > > > > The only drawback is a call to memalign. However, this is fast

Re: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-27 Thread Marek Vasut
Dear Benoît Thébaudeau, > This patch takes advantage of the hardware EHCI qTD queuing mechanism to > avoid software overhead and to make transfers as fast as possible. > > The only drawback is a call to memalign. However, this is fast compared to > the transfer timings, and the heap size to alloc

[U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed

2012-07-19 Thread Benoît Thébaudeau
This patch takes advantage of the hardware EHCI qTD queuing mechanism to avoid software overhead and to make transfers as fast as possible. The only drawback is a call to memalign. However, this is fast compared to the transfer timings, and the heap size to allocate is small, e.g. a little bit mor