Re: [U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-05-07 Thread Chris Packham
Hi Klaus, On Mon, May 7, 2018 at 8:48 PM wrote: > > On 07.05.2018, at 10:25, Chris Packham wrote: > > > > Hi Mans, Stefano, > > > > On Fri, Apr 27, 2018 at 9:00 PM Stefano Babic wrote: > > > >> On 21/04/2018 17:11, Mans Rullgard wrote: > >>> The code attempts to preserve the value of LR by s

Re: [U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-05-07 Thread Chris Packham
On Mon, May 7, 2018 at 10:11 PM Måns Rullgård wrote: > Chris Packham writes: > > Hi Mans, Stefano, > > > > On Fri, Apr 27, 2018 at 9:00 PM Stefano Babic wrote: > > > >> On 21/04/2018 17:11, Mans Rullgard wrote: > >> > The code attempts to preserve the value of LR by storing it in R12/IP > >> >

Re: [U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-05-07 Thread Måns Rullgård
Chris Packham writes: > Hi Mans, Stefano, > > On Fri, Apr 27, 2018 at 9:00 PM Stefano Babic wrote: > >> On 21/04/2018 17:11, Mans Rullgard wrote: >> > The code attempts to preserve the value of LR by storing it in R12/IP >> > across the lowevel_init() call. However, this register is not saved >

Re: [U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-05-07 Thread klaus . goger
> On 07.05.2018, at 10:25, Chris Packham wrote: > > Hi Mans, Stefano, > > On Fri, Apr 27, 2018 at 9:00 PM Stefano Babic wrote: > >> On 21/04/2018 17:11, Mans Rullgard wrote: >>> The code attempts to preserve the value of LR by storing it in R12/IP >>> across the lowevel_init() call. However

Re: [U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-05-07 Thread Chris Packham
Hi Mans, Stefano, On Fri, Apr 27, 2018 at 9:00 PM Stefano Babic wrote: > On 21/04/2018 17:11, Mans Rullgard wrote: > > The code attempts to preserve the value of LR by storing it in R12/IP > > across the lowevel_init() call. However, this register is not saved > > by the callee. Use a register

Re: [U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-04-27 Thread Stefano Babic
On 21/04/2018 17:11, Mans Rullgard wrote: > The code attempts to preserve the value of LR by storing it in R12/IP > across the lowevel_init() call. However, this register is not saved > by the callee. Use a register that guaranteed to be preserved instead. > > Signed-off-by: Mans Rullgard > ---

[U-Boot] [PATCH 2/5] ARM: arm926ejs: fix lowlevel_init call

2018-04-21 Thread Mans Rullgard
The code attempts to preserve the value of LR by storing it in R12/IP across the lowevel_init() call. However, this register is not saved by the callee. Use a register that guaranteed to be preserved instead. Signed-off-by: Mans Rullgard --- arch/arm/cpu/arm926ejs/start.S | 4 ++-- 1 file chan