Re: [U-Boot] [PATCH 2/4] s5pc1xx: support onenand driver

2009-09-04 Thread Wolfgang Denk
Dear Kyungmin Park, In message <9c9fda240909040406m2a8597d4q4b10ef55d33d6...@mail.gmail.com> you wrote: > > > PLease see comments to previous patch about usage of register plus > > offset versus using proper C structures. > > I have different opinion. How much register map is required? I mean i

Re: [U-Boot] [PATCH 2/4] s5pc1xx: support onenand driver

2009-09-04 Thread Kyungmin Park
Hi, On Fri, Sep 4, 2009 at 7:44 PM, Wolfgang Denk wrote: > Dear Minkyu Kang, > > In message <4aa0ce3f.60...@samsung.com> you wrote: >> This patch includes the onenand driver for s5pc1xx >> >> Signed-off-by: Minkyu Kang >> Signed-off-by: Kyungmin Park > ... >> +static int s3c_read_reg(int offset)

Re: [U-Boot] [PATCH 2/4] s5pc1xx: support onenand driver

2009-09-04 Thread Wolfgang Denk
Dear Minkyu Kang, In message <4aa0ce3f.60...@samsung.com> you wrote: > This patch includes the onenand driver for s5pc1xx > > Signed-off-by: Minkyu Kang > Signed-off-by: Kyungmin Park ... > +static int s3c_read_reg(int offset) > +{ > + return readl(onenand->base + offset); > +} > + > +stati

[U-Boot] [PATCH 2/4] s5pc1xx: support onenand driver

2009-09-04 Thread Minkyu Kang
This patch includes the onenand driver for s5pc1xx Signed-off-by: Minkyu Kang Signed-off-by: Kyungmin Park --- drivers/mtd/onenand/Makefile |2 + drivers/mtd/onenand/samsung.c| 624 ++ include/linux/mtd/onenand.h |1 + include/linux/mtd/