Re: [U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-12-05 Thread Wolfgang Denk
Dear Mike Frysinger, In message <20111003.15436.vap...@gentoo.org> you wrote: > > > I'm OK with expanding the name[] field, but as Thomas pointed out, > > providing "convenient" u32 / u16 variables for the MAC address is > > actually a faux ami that misleads people into using these variables >

Re: [U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-11-11 Thread Mike Frysinger
On Friday 11 November 2011 10:44:45 Andy Fleming wrote: > On Fri, Nov 11, 2011 at 9:03 AM, Mike Frysinger wrote: > > On Friday 11 November 2011 06:55:45 Wolfgang Denk wrote: > >> Mike Frysinger wrote: > >> > The current eth_device leaves a 2 byte hole after "enetaddr" and > >> > before "iobase".

Re: [U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-11-11 Thread Andy Fleming
On Fri, Nov 11, 2011 at 9:03 AM, Mike Frysinger wrote: > On Friday 11 November 2011 06:55:45 Wolfgang Denk wrote: >> Mike Frysinger wrote: >> > The current eth_device leaves a 2 byte hole after "enetaddr" and before >> > "iobase".  Since the enetaddr member has to be 6 bytes, we might as well >> >

Re: [U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-11-11 Thread Mike Frysinger
On Friday 11 November 2011 06:55:45 Wolfgang Denk wrote: > Mike Frysinger wrote: > > The current eth_device leaves a 2 byte hole after "enetaddr" and before > > "iobase". Since the enetaddr member has to be 6 bytes, we might as well > > fill that 2 byte hole with something useful. > > > > Further

Re: [U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-11-11 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1320970267-22297-2-git-send-email-vap...@gentoo.org> you wrote: > The current eth_device leaves a 2 byte hole after "enetaddr" and before > "iobase". Since the enetaddr member has to be 6 bytes, we might as well > fill that 2 byte hole with something useful. > >

Re: [U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-11-11 Thread thomas.langer
Hello Mike, > + union { > + u32 enetaddr32; > + u16 enetaddr16[3]; > + unsigned char enetaddr[6]; > + }; This will work only as long the endianess is matching. Picking single chars from enetaddr[] and combine them to a u32 register will be more indepen

[U-Boot] [PATCH 2/4] net: tweak eth_device layout to simplify enetaddr use

2011-11-10 Thread Mike Frysinger
The current eth_device leaves a 2 byte hole after "enetaddr" and before "iobase". Since the enetaddr member has to be 6 bytes, we might as well fill that 2 byte hole with something useful. Further, most device drivers want to load enetaddr from memory into the hardware as 1 32bit value and 1 16bi