Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <5bf60315-656d-4173-8722-9e2ec99aa...@boeing.com> you wrote: > > For the boards that *do* set CONFIG_PANIC_HANG, none of the fatal > errors in common/cmd_bootm.c should cause U-Boot to reset, they are > all valid panic() conditions, such as GZIP overwrite errors

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Moffett, Kyle D
On Oct 20, 2011, at 10:02, Wolfgang Denk wrote: > Dear "Moffett, Kyle D", > In message <8b4ac84d-1f22-4326-b75a-fb3cc39a5...@boeing.com> you wrote: >> >> Would you accept a patch which makes it possible for a board to not >> implement a "reset" command at all? >> >> There are a few places in comm

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <510974e8-a0c8-4e81-a034-b52f2aed1...@boeing.com> you wrote: > > > so why can't you have your do_reset() board hook negotiate with the other > > CPU > > to reset the system ? > > That's what I originally implemented. The problem is the negotiation can take > a

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-20 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <8b4ac84d-1f22-4326-b75a-fb3cc39a5...@boeing.com> you wrote: > > By that definition, my board cannot safely use U-Boot's "reset" command. You can call halt() or panic() as last stage of your reset implementation. Heh. Mike writes the same ;-) > Would you acce

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 20:23:15 Moffett, Kyle D wrote: > On Oct 19, 2011, at 20:15, Mike Frysinger wrote: > > On Wednesday 19 October 2011 18:52:10 Moffett, Kyle D wrote: > >> So U-Boot MUST NOT reset without negotiating, even if the current CPU > >> has crashed, as that will cause the other

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Moffett, Kyle D
On Oct 19, 2011, at 20:15, Mike Frysinger wrote: > On Wednesday 19 October 2011 18:52:10 Moffett, Kyle D wrote: >> So U-Boot MUST NOT reset without negotiating, even if the current CPU has >> crashed, as that will cause the other (possibly perfectly operational) CPU >> to also crash. > > so why ca

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 18:52:10 Moffett, Kyle D wrote: > So U-Boot MUST NOT reset without negotiating, even if the current CPU has > crashed, as that will cause the other (possibly perfectly operational) CPU > to also crash. so why can't you have your do_reset() board hook negotiate with the

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Moffett, Kyle D
On Oct 19, 2011, at 17:55, Mike Frysinger wrote: > On Wednesday 19 October 2011 17:05:12 Moffett, Kyle D wrote: >> On Oct 19, 2011, at 16:35, Wolfgang Denk wrote: >>> Moffett, Kyle D wrote: Since "reset" is basically just like any other U-Boot shell command, >>> >>> No, it ain't. >>> (e

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 17:05:12 Moffett, Kyle D wrote: > On Oct 19, 2011, at 16:35, Wolfgang Denk wrote: > > Moffett, Kyle D wrote: > >> Since "reset" is basically just like any other U-Boot shell command, > > > > No, it ain't. > > > >> (except with some side-effects) it seems reasonable to

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Moffett, Kyle D
On Oct 19, 2011, at 16:35, Wolfgang Denk wrote: > Dear "Moffett, Kyle D", > > In message <7c2673d7-cc5c-490c-9809-06c9a2071...@boeing.com> you wrote: >> >> Since "reset" is basically just like any other U-Boot shell command, > > No, it ain't. > >> (except with some side-effects) it seems reason

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Wolfgang Denk
Dear "Moffett, Kyle D", In message <7c2673d7-cc5c-490c-9809-06c9a2071...@boeing.com> you wrote: > > Since "reset" is basically just like any other U-Boot shell command, No, it ain't. > (except with some side-effects) it seems reasonable to allow a board > handler to return an error instead of re

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201110191452.26073.vap...@gentoo.org> you wrote: > > i thought this came up before and we said "no". but Wolfgang was more > involved in that discussion, so he should be able to better say. Yes, we said no. Best regards, Wolfgang Denk -- DENX Software Engine

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Moffett, Kyle D
On Oct 18, 2011, at 23:20, Mike Frysinger wrote: > On Tuesday 18 October 2011 19:41:23 Kyle Moffett wrote: >> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) >> +{ >> unsigned long val, msr; >> >> +/* Allow boards to override the reset */ >> +int err = __board

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 14:26:03 Moffett, Kyle D wrote: > On Oct 18, 2011, at 23:20, Mike Frysinger wrote: > > On Tuesday 18 October 2011 19:41:23 Kyle Moffett wrote: > >> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > >> +{ > >> > >>unsigned long val, msr; > >

Re: [U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-18 Thread Mike Frysinger
On Tuesday 18 October 2011 19:41:23 Kyle Moffett wrote: > +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +{ > unsigned long val, msr; > > + /* Allow boards to override the reset */ > + int err = __board_restart(); > + if (err) > + return er

[U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

2011-10-18 Thread Kyle Moffett
The HWW-1U-1A board needs to be able to override the "reset" command due to hardware design limitations. Signed-off-by: Kyle Moffett Cc: Andy Fleming Cc: Kumar Gala -- Changelog: v2: Removed in favor of more involved reset rework v6: Resurrected again (the more involved rework was NAKed) v7: