Re: [U-Boot] [PATCH 2/3] mmc: Convert mmc struct's name array to a pointer

2014-03-14 Thread Marek Vasut
On Friday, March 14, 2014 at 09:55:08 PM, Simon Glass wrote: > Hi, > > On 12 March 2014 04:24, Pantelis Antoniou wrote: > > Using an array is pointless; even more pointless (and scary) is using > > sprintf to fill it without a format string. > > This is certainly better, but how about an mmc st

Re: [U-Boot] [PATCH 2/3] mmc: Convert mmc struct's name array to a pointer

2014-03-14 Thread Simon Glass
Hi, On 12 March 2014 04:24, Pantelis Antoniou wrote: > Using an array is pointless; even more pointless (and scary) is using > sprintf to fill it without a format string. This is certainly better, but how about an mmc structure init function which sets this up? Regards, Simon __

[U-Boot] [PATCH 2/3] mmc: Convert mmc struct's name array to a pointer

2014-03-12 Thread Pantelis Antoniou
Using an array is pointless; even more pointless (and scary) is using sprintf to fill it without a format string. Signed-off-by: Pantelis Antoniou --- drivers/mmc/arm_pl180_mmci.c | 2 +- drivers/mmc/bfin_sdh.c | 2 +- drivers/mmc/davinci_mmc.c| 2 +- drivers/mmc/dw_mmc.c | 2 +