Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-20 Thread Stefano Babic
On 14/09/2015 14:11, Fabio Estevam wrote: > On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: >> We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set >> wcr, since this will override bits set before reset_cpu. >> >> Use clrsetbits_le32 instead of writew to fix this issue. > > There is a

Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-14 Thread Peng Fan
On Mon, Sep 14, 2015 at 09:11:30AM -0300, Fabio Estevam wrote: >On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: >> We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set >> wcr, since this will override bits set before reset_cpu. >> >> Use clrsetbits_le32 instead of writew to fix this issu

Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set > wcr, since this will override bits set before reset_cpu. > > Use clrsetbits_le32 instead of writew to fix this issue. There is a typo here: it should be clrsetbits_le16.

Re: [U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set > wcr, since this will override bits set before reset_cpu. > > Use clrsetbits_le32 instead of writew to fix this issue. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > Cc: Fabio Est

[U-Boot] [PATCH 2/3] imx: wdog: correct wcr register settings

2015-09-13 Thread Peng Fan
We should not simple use "writew(WCR_WDE, &wdog->wcr)" to set wcr, since this will override bits set before reset_cpu. Use clrsetbits_le32 instead of writew to fix this issue. Signed-off-by: Peng Fan Cc: Stefano Babic Cc: Fabio Estevam Cc: Sebastian Siewior --- drivers/watchdog/imx_watchdog.