Re: [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

2014-10-20 Thread Andrew Ruder
On Mon, Oct 20, 2014 at 03:17:13PM -0400, Tom Rini wrote: > You shouldn't have to add this to avoid a warning I think. And frankly, > if it does for some reason since 3/3 makes use of dev, I'm OK with a > bisect adding a trivial warning like this, rather than do compiler > games. Fair enough, the

Re: [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

2014-10-20 Thread Tom Rini
On Mon, Oct 20, 2014 at 09:59:44AM -0500, Andrew Ruder wrote: > Currently this argument is not used. To eventually support multiple > DM9000's these public-facing functions will need a new argument - the > ethernet device. Fix-up the one board using this part of the DM9000 > API. Compile-tested

Re: [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

2014-10-20 Thread Stefano Babic
Hi Andrew, On 20/10/2014 16:59, Andrew Ruder wrote: > Currently this argument is not used. To eventually support multiple > DM9000's these public-facing functions will need a new argument - the > ethernet device. Fix-up the one board using this part of the DM9000 > API. Compile-tested only. >

[U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

2014-10-20 Thread Andrew Ruder
Currently this argument is not used. To eventually support multiple DM9000's these public-facing functions will need a new argument - the ethernet device. Fix-up the one board using this part of the DM9000 API. Compile-tested only. Signed-off-by: Andrew Ruder Cc: Joe Hershberger Cc: Stefano B