Hello All,
Sorry guys, it looks like I posted the wrong version. Please discard
[v4] patch. I'll post [v5] version soon.
Regards, Ilya.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Hi Wolfgang,
Wolfgang Denk wrote:
+u32 TX_JUMBO_CNT;
+u32 TX_BYTE_CNT;
+} __attribute__((packed));
>>> Why is this packed? All fields are 32-bit aligned already.
>>>
>> Generally, I prefer declaring such structures with ((packed)) regardless
>>
Dear Ilya,
In message <49902403.2010...@emcraft.com> you wrote:
>
...
> >> +u32 TX_JUMBO_CNT;
> >> +u32 TX_BYTE_CNT;
> >> +} __attribute__((packed));
> >>
> > Why is this packed? All fields are 32-bit aligned already.
>
> Generally, I prefer declaring such structures with ((packed))
Hi Ben,
thanks for review.
Ben Warren wrote:
>> @@ -69,6 +70,7 @@ COBJS-$(CONFIG_ULI526X) += uli526x.o
>> COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o
>> COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
>> COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
>> +COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
>
Hi Ilya,
This looks much better.
Ilya Yanok wrote:
> Driver for Dave DNET ethernet controller (used on Dave/DENX
> QongEVB-LITE board).
>
> Signed-off-by: Ilya Yanok
>
> ---
> drivers/net/Makefile |2 +
> drivers/net/dnet.c | 396
> ++
Driver for Dave DNET ethernet controller (used on Dave/DENX
QongEVB-LITE board).
Signed-off-by: Ilya Yanok
---
drivers/net/Makefile |2 +
drivers/net/dnet.c | 396 ++
drivers/net/dnet.h | 166 +
include/netdev.h |
6 matches
Mail list logo
