Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-13 Thread Stephen Warren
On 11/12/2012 11:24 PM, Heiko Schocher wrote: > Hello Stephen, > > On 08.11.2012 18:05, Stephen Warren wrote: >> On 11/07/2012 11:47 PM, Heiko Schocher wrote: >>> On 01.11.2012 18:03, Stephen Warren wrote: >> ... I'd suggest having a CONFIG_SYS_I2C_DRIVERS variable at most, and each driv

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-12 Thread Wolfgang Denk
Dear Heiko, In message <50a1e780.4090...@denx.de> you wrote: > > > Equally, I think this model can work very well for manually coded board > > files; the board file can directly instantiate all top-level I2C > > adapters, and pass information to the I2C driver for those adapters > > indicating wh

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-12 Thread Heiko Schocher
Hello Stephen, On 08.11.2012 18:05, Stephen Warren wrote: On 11/07/2012 11:47 PM, Heiko Schocher wrote: On 01.11.2012 18:03, Stephen Warren wrote: ... I'd suggest having a CONFIG_SYS_I2C_DRIVERS variable at most, and each driver registers an arbitrary number of adapters and/or buses during it

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-08 Thread Simon Glass
Hi Heiko, On Wed, Nov 7, 2012 at 11:02 PM, Heiko Schocher wrote: > Hello Simon, > > > On 05.11.2012 21:39, Simon Glass wrote: >> >> Hi, >> >> On Thu, Nov 1, 2012 at 10:03 AM, Stephen Warren >> wrote: >>> >>> On 11/01/2012 01:42 AM, Heiko Schocher wrote: Hello Stephen, On 31.10

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-08 Thread Stephen Warren
On 11/07/2012 11:47 PM, Heiko Schocher wrote: > On 01.11.2012 18:03, Stephen Warren wrote: ... >> I'd suggest having a CONFIG_SYS_I2C_DRIVERS variable at most, and each >> driver registers an arbitrary number of adapters and/or buses during its >> initialization. > > Why should an i2c driver regis

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-07 Thread Heiko Schocher
Hello Simon, On 05.11.2012 21:39, Simon Glass wrote: Hi, On Thu, Nov 1, 2012 at 10:03 AM, Stephen Warren wrote: On 11/01/2012 01:42 AM, Heiko Schocher wrote: Hello Stephen, On 31.10.2012 17:25, Stephen Warren wrote: On 10/31/2012 09:56 AM, Simon Glass wrote: Hi Stephen, On Wed, Oct 31, 2

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-07 Thread Heiko Schocher
Hello Stephen, On 01.11.2012 18:03, Stephen Warren wrote: On 11/01/2012 01:42 AM, Heiko Schocher wrote: Hello Stephen, On 31.10.2012 17:25, Stephen Warren wrote: On 10/31/2012 09:56 AM, Simon Glass wrote: Hi Stephen, On Wed, Oct 31, 2012 at 8:41 AM, Stephen Warren wrote: On 10/31/2012 12

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-05 Thread Simon Glass
Hi, On Thu, Nov 1, 2012 at 10:03 AM, Stephen Warren wrote: > On 11/01/2012 01:42 AM, Heiko Schocher wrote: >> Hello Stephen, >> >> On 31.10.2012 17:25, Stephen Warren wrote: >>> On 10/31/2012 09:56 AM, Simon Glass wrote: Hi Stephen, On Wed, Oct 31, 2012 at 8:41 AM, Stephen War

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-01 Thread Stephen Warren
On 11/01/2012 01:42 AM, Heiko Schocher wrote: > Hello Stephen, > > On 31.10.2012 17:25, Stephen Warren wrote: >> On 10/31/2012 09:56 AM, Simon Glass wrote: >>> Hi Stephen, >>> >>> On Wed, Oct 31, 2012 at 8:41 AM, Stephen >>> Warren wrote: On 10/31/2012 12:00 AM, Heiko Schocher wrote: > H

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-11-01 Thread Heiko Schocher
Hello Stephen, On 31.10.2012 17:25, Stephen Warren wrote: On 10/31/2012 09:56 AM, Simon Glass wrote: Hi Stephen, On Wed, Oct 31, 2012 at 8:41 AM, Stephen Warren wrote: On 10/31/2012 12:00 AM, Heiko Schocher wrote: Hello Stephen, On 30.10.2012 23:32, Stephen Warren wrote: On 10/30/2012 11:

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-31 Thread Stephen Warren
On 10/31/2012 09:56 AM, Simon Glass wrote: > Hi Stephen, > > On Wed, Oct 31, 2012 at 8:41 AM, Stephen Warren wrote: >> On 10/31/2012 12:00 AM, Heiko Schocher wrote: >>> Hello Stephen, >>> >>> On 30.10.2012 23:32, Stephen Warren wrote: On 10/30/2012 11:28 AM, Simon Glass wrote: ... > diff

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-31 Thread Simon Glass
Hi Stephen, On Wed, Oct 31, 2012 at 8:41 AM, Stephen Warren wrote: > On 10/31/2012 12:00 AM, Heiko Schocher wrote: >> Hello Stephen, >> >> On 30.10.2012 23:32, Stephen Warren wrote: >>> On 10/30/2012 11:28 AM, Simon Glass wrote: (just for illustration, please don't merge) This enab

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-31 Thread Stephen Warren
On 10/31/2012 12:00 AM, Heiko Schocher wrote: > Hello Stephen, > > On 30.10.2012 23:32, Stephen Warren wrote: >> On 10/30/2012 11:28 AM, Simon Glass wrote: >>> (just for illustration, please don't merge) >>> >>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and >>> the Tegra >>> i

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-30 Thread Heiko Schocher
Hello Stephen, On 30.10.2012 23:32, Stephen Warren wrote: On 10/30/2012 11:28 AM, Simon Glass wrote: (just for illustration, please don't merge) This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. diff --git a/drivers/i2c/i2c_core.c b/dri

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-30 Thread Heiko Schocher
Hello Simon, On 30.10.2012 18:28, Simon Glass wrote: (just for illustration, please don't merge) This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. Signed-off-by: Simon Glass --- drivers/i2c/i2c_core.c |3 ++ drivers/i2c/tegra_i

Re: [U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-30 Thread Stephen Warren
On 10/30/2012 11:28 AM, Simon Glass wrote: > (just for illustration, please don't merge) > > This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra > i2c driver to support this. > diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c > +#ifdef CONFIG_TEGRA_I2C > +ext

[U-Boot] [PATCH 2/2] WIP: tegra: i2c: Enable new CONFIG_SYS_I2C framework

2012-10-30 Thread Simon Glass
(just for illustration, please don't merge) This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. Signed-off-by: Simon Glass --- drivers/i2c/i2c_core.c |3 ++ drivers/i2c/tegra_i2c.c | 64 +