Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2011-01-12 Thread Sergei Shtylyov
On 11.01.2011 3:31, Mike Frysinger wrote: >>> it isnt a problem to have the parens, and it keeps things sane if someone >>> does something like: >>> #define CONFIG_SYS_BD_INFO_ADDR SOME_DEFINE + 0x1000 >> This would be a violation of basic rules of defensive coding. >> Please drop these parens

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2011-01-10 Thread Mike Frysinger
On Monday, January 10, 2011 17:28:23 Wolfgang Denk wrote: > Mike Frysinger wrote: > > it isnt a problem to have the parens, and it keeps things sane if someone > > does something like: > > #define CONFIG_SYS_BD_INFO_ADDR SOME_DEFINE + 0x1000 > > This would be a violation of basic rules of defens

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2011-01-10 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201012271142.17334.vap...@gentoo.org> you wrote: > > it isnt a problem to have the parens, and it keeps things sane if someone > does > something like: > #define CONFIG_SYS_BD_INFO_ADDR SOME_DEFINE + 0x1000 This would be a violation of basic rules of defensive

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2010-12-27 Thread Mike Frysinger
On Monday, December 27, 2010 06:41:47 Sergei Shtylyov wrote: > On 27-12-2010 7:48, Mike Frysinger wrote: > > + bd = (bd_t *) (CONFIG_SYS_BD_INFO_ADDR); > > Parens not needed around CONFIG_SYS_BD_INFO_ADDR. it isnt a problem to have the parens, and it keeps things sane if someone does somet

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2010-12-27 Thread Sergei Shtylyov
Hello. On 27-12-2010 7:48, Mike Frysinger wrote: > The recent global data changes (making the size autogenerated) broke the > board info handling on Blackfin ports as we were lying and lumping the > bd_t size in with the gd_t size. So use the new dedicated bd_t size to > setup its own address in

[U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2010-12-26 Thread Mike Frysinger
The recent global data changes (making the size autogenerated) broke the board info handling on Blackfin ports as we were lying and lumping the bd_t size in with the gd_t size. So use the new dedicated bd_t size to setup its own address in memory. Signed-off-by: Mike Frysinger --- arch/blackfin