Re: [U-Boot] [PATCH 13/13] lcd: split splash code into its own function

2015-02-01 Thread Simon Glass
Hi NIkita, On 1 February 2015 at 06:59, Nikita Kiryanov wrote: > Hi Simon, > > > On 01/31/2015 02:25 AM, Simon Glass wrote: >> >> Hi Nikita, >> >> On 29 January 2015 at 04:21, Nikita Kiryanov >> wrote: >>> >>> lcd_logo() currently performs tasks well beyond just displaying the logo. >>> It has c

Re: [U-Boot] [PATCH 13/13] lcd: split splash code into its own function

2015-02-01 Thread Nikita Kiryanov
Hi Simon, On 01/31/2015 02:25 AM, Simon Glass wrote: Hi Nikita, On 29 January 2015 at 04:21, Nikita Kiryanov wrote: lcd_logo() currently performs tasks well beyond just displaying the logo. It has code which displays splash image, it has logic which determines when the different display featu

Re: [U-Boot] [PATCH 13/13] lcd: split splash code into its own function

2015-01-30 Thread Simon Glass
Hi Nikita, On 29 January 2015 at 04:21, Nikita Kiryanov wrote: > lcd_logo() currently performs tasks well beyond just displaying the logo. > It has code which displays splash image, it has logic which determines > when the different display features are displayed, and it is coupled with > the lcd

[U-Boot] [PATCH 13/13] lcd: split splash code into its own function

2015-01-29 Thread Nikita Kiryanov
lcd_logo() currently performs tasks well beyond just displaying the logo. It has code which displays splash image, it has logic which determines when the different display features are displayed, and it is coupled with the lcd console because it holds the responsibility of returning the lcd console