Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-05-13 Thread Daniel Gorsulowski
Dear Jean-Christophe, On Friday 27 March 2009 23:30 you wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > cpu/arm926ejs/at91/Makefile|6 + > .../arm926ejs/at91/at91cap9_i2c.c | 31 ++-- > .../arm926ejs/at91/at91sam9260_i2c.c

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-31 Thread Wolfgang Denk
Dear Heiko Schocher, In message <49d05e5f.6060...@denx.de> you wrote: > ... > Independent from your patch, I think we need here a common > rule. Either we name in future this define "CONFIG_I2C_XXX" > or "CONFIG_XXX_I2C. I vote for using "CONFIG_I2C_XXX" Me too. ... > > +#ifdef CONFIG_HARD_I2C

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 12:43 Mon 30 Mar , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090330085011.ga21...@game.jcrosoft.org> you wrote: > > > > > Hmm.. maybe this should be fixed in Linux too. > > IMHO no because the double tab was use to align but field of the register > > I

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090330085011.ga21...@game.jcrosoft.org> you wrote: > > > Hmm.. maybe this should be fixed in Linux too. > IMHO no because the double tab was use to align but field of the register It doesn't matter what it's being used for when it causes too lo

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD
> >>> +#ifndef AT91_TWI_H > >>> +#define AT91_TWI_H > >>> + > >>> +#define AT91_TWI_CR 0x00/* Control Register */ > >>> +#define AT91_TWI_START (1 << 0) /* Send a Start > >>> Condition */ > >>> +#define AT91_TWI_STOP (1 << 1)

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Heiko Schocher
Hello Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 07:53 Mon 30 Mar , Heiko Schocher wrote: >> Hello Jean, >> >> Jean-Christophe PLAGNIOL-VILLARD wrote: >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD >>> --- >>> cpu/arm926ejs/at91/Makefile|6

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 07:53 Mon 30 Mar , Heiko Schocher wrote: > Hello Jean, > > Jean-Christophe PLAGNIOL-VILLARD wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > cpu/arm926ejs/at91/Makefile|6 + > > .../arm926ejs/at91/at91cap9_i2c.c | 31 ++-

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-29 Thread Heiko Schocher
Hello Jean, Jean-Christophe PLAGNIOL-VILLARD wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > cpu/arm926ejs/at91/Makefile|6 + > .../arm926ejs/at91/at91cap9_i2c.c | 31 ++-- > .../arm926ejs/at91/at91sam9260_i2c.c | 31

[U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-27 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD --- cpu/arm926ejs/at91/Makefile|6 + .../arm926ejs/at91/at91cap9_i2c.c | 31 ++-- .../arm926ejs/at91/at91sam9260_i2c.c | 31 ++-- .../arm926ejs/at91/at91sam9261_i2c.c | 3