Re: [U-Boot] [PATCH 10/33] rtc: mc146818: Set up RTC at start of day

2014-11-12 Thread Simon Glass
Hi Wolfgang, On 12 November 2014 01:12, Wolfgang Denk wrote: > Dear Simon, > > In message <1415751501-23407-11-git-send-email-...@chromium.org> you wrote: >> If the RTC needs to be cleared, write the U-Boot build date to it. In any >> case make sure the settings are correct. > > Is this really a

Re: [U-Boot] [PATCH 10/33] rtc: mc146818: Set up RTC at start of day

2014-11-12 Thread Wolfgang Denk
Dear Simon, In message <1415751501-23407-11-git-send-email-...@chromium.org> you wrote: > If the RTC needs to be cleared, write the U-Boot build date to it. In any > case make sure the settings are correct. Is this really a good idea? Why writing the build date? It is as wrong as any other arbi

Re: [U-Boot] [PATCH 10/33] rtc: mc146818: Set up RTC at start of day

2014-11-11 Thread Bin Meng
Hi Simon, On Wed, Nov 12, 2014 at 8:17 AM, Simon Glass wrote: > If the RTC needs to be cleared, write the U-Boot build date to it. In any > case make sure the settings are correct. > > Signed-off-by: Simon Glass > --- > > drivers/rtc/mc146818.c | 49 +

[U-Boot] [PATCH 10/33] rtc: mc146818: Set up RTC at start of day

2014-11-11 Thread Simon Glass
If the RTC needs to be cleared, write the U-Boot build date to it. In any case make sure the settings are correct. Signed-off-by: Simon Glass --- drivers/rtc/mc146818.c | 49 + include/rtc.h | 7 +++ 2 files changed, 52 insertions(+)