Re: [U-Boot] [PATCH 10/10] avb_verify: support using OP-TEE TA AVB

2018-08-16 Thread Igor Opaniuk
Hi Jens, Minor issue: There should be some error message when we try to write ф rollback index, which value is less than existing. For example: poplar# avb write_rb 1 4 poplar# avb read_rb 1 Rollback index: 4 poplar# avb write_rb 1 3 // Should print error message here poplar# avb read_rb 1 Rollb

Re: [U-Boot] [PATCH 10/10] avb_verify: support using OP-TEE TA AVB

2018-08-14 Thread Igor Opaniuk
Hi Jens, Could you please also add info about CONFIG_OPTEE_TA_AVB to the existing doc/README.avb2 and more description of how/where rollback indexes/device lock state are stored (this what you explained in the cover letter for this patchset). Thanks On 13 August 2018 at 18:53, Jens Wiklander wr

[U-Boot] [PATCH 10/10] avb_verify: support using OP-TEE TA AVB

2018-08-13 Thread Jens Wiklander
With CONFIG_OPTEE_TA_AVB use the trusted application AVB provided by OP-TEE to manage rollback indexes and device lock status. Signed-off-by: Jens Wiklander --- common/avb_verify.c | 132 ++- include/avb_verify.h | 4 ++ 2 files changed, 135 insertions(