Re: [U-Boot] [PATCH 1/8] x86: fsp: Simplify fsp_continue()

2015-12-03 Thread Simon Glass
Hi Bin, On 2 December 2015 at 22:11, Bin Meng wrote: > Hi Simon, > > On Thu, Dec 3, 2015 at 5:05 AM, Simon Glass wrote: >> Hi Bin, >> >> On 2 December 2015 at 01:58, Bin Meng wrote: >>> There is no need to pass shared_data to fsp_continue() so we can >>> remove unnecessary codes that simplifies

Re: [U-Boot] [PATCH 1/8] x86: fsp: Simplify fsp_continue()

2015-12-02 Thread Bin Meng
Hi Simon, On Thu, Dec 3, 2015 at 5:05 AM, Simon Glass wrote: > Hi Bin, > > On 2 December 2015 at 01:58, Bin Meng wrote: >> There is no need to pass shared_data to fsp_continue() so we can >> remove unnecessary codes that simplifies the function a lot. > > Is this because shared_data is effective

Re: [U-Boot] [PATCH 1/8] x86: fsp: Simplify fsp_continue()

2015-12-02 Thread Simon Glass
Hi Bin, On 2 December 2015 at 01:58, Bin Meng wrote: > There is no need to pass shared_data to fsp_continue() so we can > remove unnecessary codes that simplifies the function a lot. Is this because shared_data is effectively useful for a bootloader due to the stack being changed? > > Signed-of

[U-Boot] [PATCH 1/8] x86: fsp: Simplify fsp_continue()

2015-12-02 Thread Bin Meng
There is no need to pass shared_data to fsp_continue() so we can remove unnecessary codes that simplifies the function a lot. Signed-off-by: Bin Meng --- arch/x86/include/asm/fsp/fsp_support.h | 4 +--- arch/x86/lib/fsp/fsp_support.c | 29 ++--- 2 files changed,