Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-04 Thread Marek Vasut
On Tuesday, October 04, 2011 10:44:28 PM Wolfgang Denk wrote: > Dear Mike Frysinger, > > In message <201110041546.41827.vap...@gentoo.org> you wrote: > > > Please revert the "GCC4.6: Convert various empty macros to inline > > > functions". Please consider this a final confirmation. > > > > to be

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-04 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201110041546.41827.vap...@gentoo.org> you wrote: > > > Please revert the "GCC4.6: Convert various empty macros to inline > > functions". Please consider this a final confirmation. > > to be clear, we will want this back eventually :) Agreed. But in a form that 1

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-04 Thread Mike Frysinger
On Tuesday 04 October 2011 15:06:43 Marek Vasut wrote: > On Tuesday, October 04, 2011 02:18:23 PM Marek Vasut wrote: > > On Monday, October 03, 2011 08:36:58 PM Wolfgang Denk wrote: > > > Marek Vasut wrote: > > > > Wolfgang, can you please revert this patch ? It should get the PPCs > > > > building

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-04 Thread Wolfgang Denk
Dear Marek Vasut, In message <201110042106.43968.marek.va...@gmail.com> you wrote: > > Please revert the "GCC4.6: Convert various empty macros to inline functions". > Please consider this a final confirmation. Thanks, reverted. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-04 Thread Marek Vasut
On Tuesday, October 04, 2011 02:18:23 PM Marek Vasut wrote: > On Monday, October 03, 2011 08:36:58 PM Wolfgang Denk wrote: > > Dear Marek Vasut, > > > > In message <201110032032.25013.marek.va...@gmail.com> you wrote: > > > Wolfgang, can you please revert this patch ? It should get the PPCs > > >

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-04 Thread Marek Vasut
On Monday, October 03, 2011 08:36:58 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201110032032.25013.marek.va...@gmail.com> you wrote: > > Wolfgang, can you please revert this patch ? It should get the PPCs > > building again, but I feel like it's more like hiding errors. As a > > t

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-03 Thread Marek Vasut
On Monday, October 03, 2011 08:42:59 PM Marek Vasut wrote: > On Monday, October 03, 2011 08:36:58 PM Wolfgang Denk wrote: > > Dear Marek Vasut, > > > > In message <201110032032.25013.marek.va...@gmail.com> you wrote: > > > Wolfgang, can you please revert this patch ? It should get the PPCs > > > b

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-03 Thread Marek Vasut
On Monday, October 03, 2011 08:36:58 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201110032032.25013.marek.va...@gmail.com> you wrote: > > Wolfgang, can you please revert this patch ? It should get the PPCs > > building again, but I feel like it's more like hiding errors. As a > > t

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-03 Thread Wolfgang Denk
Dear Marek Vasut, In message <201110032032.25013.marek.va...@gmail.com> you wrote: > > Wolfgang, can you please revert this patch ? It should get the PPCs building > again, but I feel like it's more like hiding errors. As a temporary solution > (until I come up with something better), this shoul

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-10-03 Thread Marek Vasut
On Monday, September 26, 2011 02:26:00 AM Marek Vasut wrote: > Fixes problems similar to the following ones: > > cmd_date.c: In function ‘do_date’: > cmd_date.c:50:6: warning: variable ‘old_bus’ set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Marek Vasut > --- Wolfgang, can yo

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-09-26 Thread Wolfgang Denk
Dear Marek Vasut, In message <201109261104.13082.marek.va...@gmail.com> you wrote: > > > Your commit log does not match your patch. > > "Fixes problems similar to the following ones" ... why not ? Please show _exactly_ which problems the patch fixes. Best regards, Wolfgang Denk -- DENX Softw

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 04:39:42 AM Fabio Estevam wrote: > On Sun, Sep 25, 2011 at 9:26 PM, Marek Vasut wrote: > > Fixes problems similar to the following ones: > > > > cmd_date.c: In function ‘do_date’: > > cmd_date.c:50:6: warning: variable ‘old_bus’ set but not used > > [-Wunused-but-set

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-09-25 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-09-25 Thread Fabio Estevam
On Sun, Sep 25, 2011 at 9:26 PM, Marek Vasut wrote: > Fixes problems similar to the following ones: > > cmd_date.c: In function ‘do_date’: > cmd_date.c:50:6: warning: variable ‘old_bus’ set but not used > [-Wunused-but-set-variable] Your commit log does not match your patch.

[U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions

2011-09-25 Thread Marek Vasut
Fixes problems similar to the following ones: cmd_date.c: In function ‘do_date’: cmd_date.c:50:6: warning: variable ‘old_bus’ set but not used [-Wunused-but-set-variable] Signed-off-by: Marek Vasut --- common/usb.c |4 ++-- common/usb_storage.c |2 +- include/common.h |4