Re: [U-Boot] [PATCH 1/7] spi: update management of default speed and mode

2018-12-12 Thread Jagan Teki
On Mon, Dec 10, 2018 at 4:23 PM Patrick Delaunay wrote: > > The 2 default values for SPI mode and speed are > only if CONFIG_DM_SPI_FLASH is not defined > - CONFIG_SF_DEFAULT_SPEED > - CONFIG_SF_DEFAULT_MODE > > Inverse the logic of the test to remove these two defines. > > Signed-off-by: Patrick

Re: [U-Boot] [PATCH 1/7] spi: update management of default speed and mode

2018-12-10 Thread Simon Goldschmidt
Am 10.12.2018 um 21:49 schrieb Petr Vorel: Hi Patrick, On Mon, Dec 10, 2018 at 11:53 AM Patrick Delaunay wrote: The 2 default values for SPI mode and speed are only if CONFIG_DM_SPI_FLASH is not defined - CONFIG_SF_DEFAULT_SPEED - CONFIG_SF_DEFAULT_MODE Inverse the logic of the test to r

Re: [U-Boot] [PATCH 1/7] spi: update management of default speed and mode

2018-12-10 Thread Petr Vorel
Hi Patrick, > On Mon, Dec 10, 2018 at 11:53 AM Patrick Delaunay > wrote: > > The 2 default values for SPI mode and speed are > > only if CONFIG_DM_SPI_FLASH is not defined > > - CONFIG_SF_DEFAULT_SPEED > > - CONFIG_SF_DEFAULT_MODE > > Inverse the logic of the test to remove these two defines.

Re: [U-Boot] [PATCH 1/7] spi: update management of default speed and mode

2018-12-10 Thread Simon Goldschmidt
On Mon, Dec 10, 2018 at 11:53 AM Patrick Delaunay wrote: > > The 2 default values for SPI mode and speed are > only if CONFIG_DM_SPI_FLASH is not defined > - CONFIG_SF_DEFAULT_SPEED > - CONFIG_SF_DEFAULT_MODE > > Inverse the logic of the test to remove these two defines. > > Signed-off-by: Patrick

[U-Boot] [PATCH 1/7] spi: update management of default speed and mode

2018-12-10 Thread Patrick Delaunay
The 2 default values for SPI mode and speed are only if CONFIG_DM_SPI_FLASH is not defined - CONFIG_SF_DEFAULT_SPEED - CONFIG_SF_DEFAULT_MODE Inverse the logic of the test to remove these two defines. Signed-off-by: Patrick Delaunay --- cmd/sf.c | 10 ++ common/spl/spl_sp