Re: [U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-23 Thread Pavel Machek
On Wed 2014-10-22 21:55:58, Marek Vasut wrote: > Zap the offset-based register access and use the struct-based one > as this is the preferred method. > > No functional change, but there are some line-over-80 problems in > the driver, which will be addressed later. For 1-7: Acked-by: Pavel Machek

[U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-22 Thread Marek Vasut
Zap the offset-based register access and use the struct-based one as this is the preferred method. No functional change, but there are some line-over-80 problems in the driver, which will be addressed later. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dinh Nguyen Cc: Albert Aribaud Cc:

Re: [U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-21 Thread Marek Vasut
On Monday, October 20, 2014 at 07:19:33 PM, Jagan Teki wrote: > On 20 October 2014 20:40, Marek Vasut wrote: > > On Monday, October 20, 2014 at 04:53:15 PM, Jagan Teki wrote: > > > > [...] > > > >> > -#define ALTERA_SPI_RXDATA 0 > >> > -#define ALTERA_SPI_TXDATA 4 > >> > -#define ALTER

Re: [U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-20 Thread Jagan Teki
On 20 October 2014 20:40, Marek Vasut wrote: > On Monday, October 20, 2014 at 04:53:15 PM, Jagan Teki wrote: > > [...] > >> > -#define ALTERA_SPI_RXDATA 0 >> > -#define ALTERA_SPI_TXDATA 4 >> > -#define ALTERA_SPI_STATUS 8 >> > -#define ALTERA_SPI_CONTROL 12 >> > -#define ALTERA

Re: [U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-20 Thread Marek Vasut
On Monday, October 20, 2014 at 04:53:15 PM, Jagan Teki wrote: [...] > > -#define ALTERA_SPI_RXDATA 0 > > -#define ALTERA_SPI_TXDATA 4 > > -#define ALTERA_SPI_STATUS 8 > > -#define ALTERA_SPI_CONTROL 12 > > -#define ALTERA_SPI_SLAVE_SEL 20 > > +struct altera_spi_regs { > > +

Re: [U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-20 Thread Jagan Teki
On 20 October 2014 00:13, Marek Vasut wrote: > Zap the offset-based register access and use the struct-based one > as this is the preferred method. > > No functional change, but there are some line-over-80 problems in > the driver, which will be addressed later. > > Signed-off-by: Marek Vasut > C

Re: [U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-20 Thread Pavel Machek
On Sun 2014-10-19 20:43:33, Marek Vasut wrote: > Zap the offset-based register access and use the struct-based one > as this is the preferred method. > > No functional change, but there are some line-over-80 problems in > the driver, which will be addressed later. For the whole series, Acked-by:

[U-Boot] [PATCH 1/7] spi: altera: Use struct-based register access

2014-10-19 Thread Marek Vasut
Zap the offset-based register access and use the struct-based one as this is the preferred method. No functional change, but there are some line-over-80 problems in the driver, which will be addressed later. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dinh Nguyen Cc: Albert Aribaud Cc: