Re: [U-Boot] [PATCH 1/7] dfu:usb: Support for g_dnl composite download gadget.

2012-07-24 Thread Mike Frysinger
On Monday 23 July 2012 11:25:25 Lukasz Majewski wrote: > Dear Mike Frysinger, > > On Tuesday 03 July 2012 05:38:05 Lukasz Majewski wrote: > > > +{ > > > + int ret; > > > + static char str[16]; > > > + > > > + memset(str, '\0', sizeof(str)); > > > + > > > + strncpy(str, shortname, sizeof(shortname))

Re: [U-Boot] [PATCH 1/7] dfu:usb: Support for g_dnl composite download gadget.

2012-07-23 Thread Lukasz Majewski
Dear Mike Frysinger, Thank you for thorough review. > On Tuesday 03 July 2012 05:38:05 Lukasz Majewski wrote: > > --- /dev/null > > +++ b/drivers/usb/gadget/g_dnl.c > > > > +static const char shortname[] = "usb_dnl_"; > > shortname -> gadget_name_prefix This might be only matter of taste, but i

Re: [U-Boot] [PATCH 1/7] dfu:usb: Support for g_dnl composite download gadget.

2012-07-19 Thread Mike Frysinger
On Tuesday 03 July 2012 05:38:05 Lukasz Majewski wrote: > --- /dev/null > +++ b/drivers/usb/gadget/g_dnl.c > > +static const char shortname[] = "usb_dnl_"; shortname -> gadget_name_prefix > +static void g_dnl_suspend(struct usb_composite_dev *cdev) > +{ > + if (cdev->gadget->speed == USB_SPEE

Re: [U-Boot] [PATCH 1/7] dfu:usb: Support for g_dnl composite download gadget.

2012-07-04 Thread Lukasz Majewski
Hi Marek, Thanks for review. > Dear Lukasz Majewski, > > > Composite USB download gadget support (g_dnl) for download > > functions. This code works on top of composite gadget. > > > > Signed-off-by: Lukasz Majewski > > Signed-off-by: Kyungmin Park > > Cc: Marek Vasut > > --- > > drivers/us

Re: [U-Boot] [PATCH 1/7] dfu:usb: Support for g_dnl composite download gadget.

2012-07-03 Thread Marek Vasut
Dear Lukasz Majewski, > Composite USB download gadget support (g_dnl) for download functions. > This code works on top of composite gadget. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Marek Vasut > --- > drivers/usb/gadget/Makefile |1 + > drivers/usb/gadget/g_

[U-Boot] [PATCH 1/7] dfu:usb: Support for g_dnl composite download gadget.

2012-07-03 Thread Lukasz Majewski
Composite USB download gadget support (g_dnl) for download functions. This code works on top of composite gadget. Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park Cc: Marek Vasut --- drivers/usb/gadget/Makefile |1 + drivers/usb/gadget/g_dnl.c | 235 +++