Re: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-10 Thread Masahiro Yamada
Hi Marek, On Thu, 10 Jul 2014 13:30:38 +0200 Marek Vasut wrote: > > > > > > + > > > > > > + /* setup the pipeline command */ > > > > > > + index_addr(cmd, 0x2000 | page_count); > > > > > > > > > > Magic value 0x2000 should be fixed here. > > > > > > > > Actually, this part is the same as

Re: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-10 Thread Marek Vasut
On Thursday, July 10, 2014 at 12:52:19 PM, Masahiro Yamada wrote: > Hi Marek, Hi! [...] > > Or just use put_unaligned() ? > > Oh, year! put_unaligned() would be better. > Thanks! > > > > > > + > > > > > + /* setup the pipeline command */ > > > > > + index_addr(cmd, 0x2000 | page_count

Re: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-10 Thread Masahiro Yamada
Hi Marek, On Thu, 10 Jul 2014 12:10:25 +0200 Marek Vasut wrote: > > > On Fri, 4 Jul 2014 16:34:11 +0200 > > > > Marek Vasut wrote: > > > > +static void read_data_from_flash_mem(uint8_t *buf, int len) > > > > +{ > > > > + int i; > > > > + uint32_t *buf32; > > > > + > > > > +

Re: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-10 Thread Marek Vasut
On Thursday, July 10, 2014 at 12:06:20 PM, Masahiro Yamada wrote: > Hi Marek, Hi! > On Fri, 4 Jul 2014 16:34:11 +0200 > > Marek Vasut wrote: > > > +static void read_data_from_flash_mem(uint8_t *buf, int len) > > > +{ > > > + int i; > > > + uint32_t *buf32; > > > + > > > + /* transfer the data f

Re: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-10 Thread Masahiro Yamada
Hi Marek, On Fri, 4 Jul 2014 16:34:11 +0200 Marek Vasut wrote: > > > +static void read_data_from_flash_mem(uint8_t *buf, int len) > > +{ > > + int i; > > + uint32_t *buf32; > > + > > + /* transfer the data from the flash */ > > + buf32 = (uint32_t *)buf; > > + for (i = 0; i < len / 4

Re: [U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-04 Thread Marek Vasut
On Friday, July 04, 2014 at 12:19:13 PM, Masahiro Yamada wrote: > The SPL-mode driver for Denali(Cadence) NAND Flash Memory Controller IP. > > This driver requires two CONFIG macros: > - CONFIG_NAND_DENALI > Define to enable this driver. > - CONFIG_SYS_NAND_BAD_BLOCK_POS > Specify bad

[U-Boot] [PATCH 1/6] nand: denali: add Denali NAND driver for SPL

2014-07-04 Thread Masahiro Yamada
The SPL-mode driver for Denali(Cadence) NAND Flash Memory Controller IP. This driver requires two CONFIG macros: - CONFIG_NAND_DENALI Define to enable this driver. - CONFIG_SYS_NAND_BAD_BLOCK_POS Specify bad block mark position in the oob space. Typically 0. Signed-off-by: Masahiro Ya